From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8137587224946496306==" MIME-Version: 1.0 From: Florian Westphal To: kbuild-all@lists.01.org Subject: Re: [netfilter-nf-next:testing 1/6] net/netfilter/nf_conntrack_proto_tcp.c:592:32: warning: implicit conversion from 'enum ' to 'enum nf_ct_tcp_action' Date: Thu, 01 Sep 2022 14:42:13 +0200 Message-ID: <20220901124213.GB7349@breakpoint.cc> In-Reply-To: <202209012010.OWTXJac6-lkp@intel.com> List-Id: --===============8137587224946496306== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable kernel test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf-next.g= it testing > head: 655d797bf5e11676f7ef9e68af3e9700404f8695 > commit: 83d3b17508cc0f1a53b73080c51e57054ddf3499 [1/6] netfilter: conntra= ck: prepare tcp_in_window for ternary return value > config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/202209= 01/202209012010.OWTXJac6-lkp(a)intel.com/config) > compiler: m68k-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=3D1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi= n/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf-ne= xt.git/commit/?id=3D83d3b17508cc0f1a53b73080c51e57054ddf3499 > git remote add netfilter-nf-next git://git.kernel.org/pub/scm/lin= ux/kernel/git/netfilter/nf-next.git > git fetch --no-tags netfilter-nf-next testing > git checkout 83d3b17508cc0f1a53b73080c51e57054ddf3499 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-12.1.0 make.cro= ss W=3D1 O=3Dbuild_dir ARCH=3Dm68k SHELL=3D/bin/bash net/netfilter/ > = > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > = > All warnings (new ones prefixed by >>): > = > net/netfilter/nf_conntrack_proto_tcp.c: In function 'tcp_in_window': > >> net/netfilter/nf_conntrack_proto_tcp.c:592:32: warning: implicit conve= rsion from 'enum ' to 'enum nf_ct_tcp_action' [-Wenum-conversion] > 592 | return true; > | ^~~~ I'll squash this fix: if (dir =3D=3D IP_CT_DIR_REPLY && !tcph->ack) - return true; + return NFCT_TCP_ACCEPT; --===============8137587224946496306==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE246ECAAD3 for ; Thu, 1 Sep 2022 12:42:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233070AbiIAMm1 (ORCPT ); Thu, 1 Sep 2022 08:42:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233033AbiIAMmZ (ORCPT ); Thu, 1 Sep 2022 08:42:25 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ED6C115E for ; Thu, 1 Sep 2022 05:42:23 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1oTjWP-0002Jj-Ao; Thu, 01 Sep 2022 14:42:13 +0200 Date: Thu, 1 Sep 2022 14:42:13 +0200 From: Florian Westphal To: kernel test robot Cc: Florian Westphal , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: [netfilter-nf-next:testing 1/6] net/netfilter/nf_conntrack_proto_tcp.c:592:32: warning: implicit conversion from 'enum ' to 'enum nf_ct_tcp_action' Message-ID: <20220901124213.GB7349@breakpoint.cc> References: <202209012010.OWTXJac6-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202209012010.OWTXJac6-lkp@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kernel test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf-next.git testing > head: 655d797bf5e11676f7ef9e68af3e9700404f8695 > commit: 83d3b17508cc0f1a53b73080c51e57054ddf3499 [1/6] netfilter: conntrack: prepare tcp_in_window for ternary return value > config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220901/202209012010.OWTXJac6-lkp@intel.com/config) > compiler: m68k-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf-next.git/commit/?id=83d3b17508cc0f1a53b73080c51e57054ddf3499 > git remote add netfilter-nf-next git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf-next.git > git fetch --no-tags netfilter-nf-next testing > git checkout 83d3b17508cc0f1a53b73080c51e57054ddf3499 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash net/netfilter/ > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > net/netfilter/nf_conntrack_proto_tcp.c: In function 'tcp_in_window': > >> net/netfilter/nf_conntrack_proto_tcp.c:592:32: warning: implicit conversion from 'enum ' to 'enum nf_ct_tcp_action' [-Wenum-conversion] > 592 | return true; > | ^~~~ I'll squash this fix: if (dir == IP_CT_DIR_REPLY && !tcph->ack) - return true; + return NFCT_TCP_ACCEPT;