From: Jakub Kicinski <kuba@kernel.org>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: <pabeni@redhat.com>, <edumazet@google.com>, <davem@davemloft.net>,
<kuni1840@gmail.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v3 net-next 3/5] tcp: Access &tcp_hashinfo via net.
Date: Thu, 1 Sep 2022 14:49:36 -0700 [thread overview]
Message-ID: <20220901144936.4aaef04b@kernel.org> (raw)
In-Reply-To: <20220901212520.11421-1-kuniyu@amazon.com>
On Thu, 1 Sep 2022 14:25:20 -0700 Kuniyuki Iwashima wrote:
> > I looks to me that the above chunks are functionally a no-op and I
> > think that omitting the 2 drivers from the v2:
> >
> > https://lore.kernel.org/netdev/20220829161920.99409-4-kuniyu@amazon.com/
> >
> > should break mlx5/nfp inside a netns. I don't understand why including
> > the above and skipping the latters?!? I guess is a question mostly for
> > Eric :)
>
> My best guess is that it's ok unless it does not touch TCP stack deeply
> and if it does, the driver developer must catch up with the core changes
> not to burden maintainers...?
>
> If so, I understand that take. OTOH, I also don't want to break anything
> when we know the change would do.
>
> So, I'm fine to either stay as is or add the change in v4 again.
FWIW I share Paolo's concern. If we don't want the drivers to be
twiddling with the hash tables we should factor out that code to
a common helper in net/tls/
next prev parent reply other threads:[~2022-09-01 21:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 19:15 [PATCH v3 net-next 0/5] tcp: Introduce optional per-netns ehash Kuniyuki Iwashima
2022-08-30 19:15 ` [PATCH v3 net-next 1/5] tcp: Clean up some functions Kuniyuki Iwashima
2022-08-30 19:15 ` [PATCH v3 net-next 2/5] tcp: Set NULL to sk->sk_prot->h.hashinfo Kuniyuki Iwashima
2022-08-30 19:15 ` [PATCH v3 net-next 3/5] tcp: Access &tcp_hashinfo via net Kuniyuki Iwashima
2022-09-01 10:57 ` Paolo Abeni
2022-09-01 21:25 ` Kuniyuki Iwashima
2022-09-01 21:30 ` Eric Dumazet
2022-09-01 22:12 ` Kuniyuki Iwashima
2022-09-03 0:44 ` Kuniyuki Iwashima
2022-09-03 0:53 ` Eric Dumazet
2022-09-03 1:12 ` Kuniyuki Iwashima
2022-09-03 1:44 ` Kuniyuki Iwashima
2022-09-03 2:30 ` Eric Dumazet
2022-09-03 2:50 ` Kuniyuki Iwashima
2022-09-03 3:16 ` Eric Dumazet
2022-09-03 3:25 ` Kuniyuki Iwashima
2022-09-01 21:49 ` Jakub Kicinski [this message]
2022-09-01 22:19 ` Kuniyuki Iwashima
2022-08-30 19:15 ` [PATCH v3 net-next 4/5] tcp: Save unnecessary inet_twsk_purge() calls Kuniyuki Iwashima
2022-08-30 19:15 ` [PATCH v3 net-next 5/5] tcp: Introduce optional per-netns ehash Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220901144936.4aaef04b@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.