From: "Hervé Poussineau" <hpoussin@reactos.org>
To: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,
qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, "Hervé Poussineau" <hpoussin@reactos.org>
Subject: [PATCH 1/2] vvfat: allow some writes to bootsector
Date: Sat, 3 Sep 2022 18:23:01 +0200 [thread overview]
Message-ID: <20220903162302.3176003-2-hpoussin@reactos.org> (raw)
In-Reply-To: <20220903162302.3176003-1-hpoussin@reactos.org>
'reserved1' field in bootsector is used to mark volume dirty, or need to verify.
Allow writes to bootsector which only changes the 'reserved1' field.
This fixes I/O errors on Windows guests.
Resolves: https://bugs.launchpad.net/qemu/+bug/1889421
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
block/vvfat.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index d6dd919683d..35057a51c67 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -2993,11 +2993,27 @@ DLOG(checkpoint());
vvfat_close_current_file(s);
+ if (sector_num == s->offset_to_bootsector && nb_sectors == 1) {
+ /*
+ * Write on bootsector. Allow only changing the reserved1 field,
+ * used to mark volume dirtiness
+ */
+ const unsigned char *initial = s->first_sectors
+ + s->offset_to_bootsector * 0x200;
+ for (i = 0; i < 0x200; i++) {
+ if (i != offsetof(bootsector_t, u.fat16.reserved1) &&
+ initial[i] != buf[i]) {
+ fprintf(stderr, "Tried to write to protected bootsector\n");
+ return -1;
+ }
+ }
+ return 0;
+ }
+
/*
* Some sanity checks:
* - do not allow writing to the boot sector
*/
-
if (sector_num < s->offset_to_fat)
return -1;
--
2.36.2
next prev parent reply other threads:[~2022-09-03 16:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-03 16:23 [PATCH 0/2] Fix some problems with vvfat in R/W mode Hervé Poussineau
2022-09-03 16:23 ` Hervé Poussineau [this message]
2022-09-29 14:10 ` [PATCH 1/2] vvfat: allow some writes to bootsector Kevin Wolf
2022-09-29 19:53 ` Hervé Poussineau
2022-09-30 9:57 ` Kevin Wolf
2022-09-03 16:23 ` [PATCH 2/2] vvfat: allow spaces in file names Hervé Poussineau
2022-09-04 13:45 ` Philippe Mathieu-Daudé via
2022-09-29 14:24 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220903162302.3176003-2-hpoussin@reactos.org \
--to=hpoussin@reactos.org \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.