From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1oV8v8-0005T6-1d for mharc-grub-devel@gnu.org; Mon, 05 Sep 2022 06:01:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oV8v5-0005PI-9X for grub-devel@gnu.org; Mon, 05 Sep 2022 06:01:31 -0400 Received: from mail-am6eur05on20630.outbound.protection.outlook.com ([2a01:111:f400:7e1b::630]:30529 helo=EUR05-AM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oV8ux-0002N6-3I for grub-devel@gnu.org; Mon, 05 Sep 2022 06:01:30 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lLhrdBSsiQBUy90jWWjWMo98xrj1z6n69f4YeRZxUx5S99eX9PdfuzXMYXKCasTGjorAVpNI81Cb2XN+r2nynCzjY2Ci03Wv6bzGmbadXKT0KNJrvb4/j1XhpBjtEOVBp8RaIWG2k6V5CtDIlHtJr6TCGe5TY6jhRLGt3F0wiTIWNuseH4dvqRvFMTTj/cXNajNTKQRdF3m8JI0985uCdUyRrRfouJPo4uExISPXXFTb/88S9f/BLix/gbX0N3bxQccP8iHPQsYuWaCsIfKH3F/my10Y1IrY10evTZr0W0pIEfmki0SsUqh49k2f3p9f+0m1/ncDz+8j1jlp8JR1YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1VFTLCZQICbNL/cluMo7S8MnnDccN8weZkq/tf0pA2s=; b=PYKP18XfS674ATgwkUVEKpoPOY0EFf/hkpDl3jD+ROMMsFZln8CRc8obda6NQVSnaH+YaAdvZDLZMUcUsoyYF2Y3A7+1eVY/5j0Lj0RwWeOsIvR2IIYpye8rnwEsn4CzJaqAj3e2lpiJ93LqbRNw+E7OFJuBOSL5DF/4+I9JuYoFVBsIehiSBfRTVWayiuVNd5cNONGeXgp6MYk7T/s435VVI6fuGtBPzGqBRem1ZyEuplEQzdgpu2UFd422yNij4ldS3Yui/lxTbbl/EAviUnR+RliU96pmzsPmox8pSYcGa426ohyRyuNy1/Cl+Qr3YEZQcR2ILdjSo9jwQKcNtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1VFTLCZQICbNL/cluMo7S8MnnDccN8weZkq/tf0pA2s=; b=IZFhODve0yQsKQBIxn469C1M1VzHrdfcTsM06BS1e/uUT6Ms1pP3zBxtuXrM4i+Fi02fwTkjbjtqBf2cnjAQ0OtfophbXa41f2idNsVPsBvtIiQM+rC4a0EhhWwhQ7oyTi2JGOkg3Uaxyz0y+uJcrpctvPnfau/AuXlGrGZtOPtwuQxyhsQjyOypEMMnJi61kAIg9Bm2h7cB7NSzdIpB5x2elEvDdgLv3XOEjB9PxtJC3pK8nimtziW4g1pGsRekn/3AsHlZXm81em1Gx3exmtUGfcVfN0AhQf+/OaH++L8tVR8t2sroUC4W0DUclC/8/dhyZbc8/gdQGg9jWDxYiw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB9081.eurprd04.prod.outlook.com (2603:10a6:10:2f0::13) by AM6PR04MB4727.eurprd04.prod.outlook.com (2603:10a6:20b:3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.16; Mon, 5 Sep 2022 09:56:16 +0000 Received: from DU2PR04MB9081.eurprd04.prod.outlook.com ([fe80::dde8:aa4e:20d0:c5c7]) by DU2PR04MB9081.eurprd04.prod.outlook.com ([fe80::dde8:aa4e:20d0:c5c7%3]) with mapi id 15.20.5588.018; Mon, 5 Sep 2022 09:56:15 +0000 Date: Mon, 5 Sep 2022 17:56:07 +0800 From: Michael Chang To: The development of GNU GRUB Cc: Ismael Luceno Subject: Re: [PATCH v2 1/2] grub-install: Add missing points of no return for IEEE1275 on i386/powerpc Message-ID: <20220905095607.GA10914@mazu> References: <20220829143625.23769-1-iluceno@suse.de> <20220829143625.23769-2-iluceno@suse.de> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220829143625.23769-2-iluceno@suse.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: TYCPR01CA0177.jpnprd01.prod.outlook.com (2603:1096:400:2b2::16) To DU2PR04MB9081.eurprd04.prod.outlook.com (2603:10a6:10:2f0::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4bf52b25-06c4-4ef5-5e5d-08da8f24df54 X-MS-TrafficTypeDiagnostic: AM6PR04MB4727:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2Rl0cc7wFoYlDNXXSsAAJYPO4HM6ghJEI+UwXEwzv/6TdXwG65c4eLAbcG4pTTYgpcYJtwFTdA5SLVLMv+cfbQiWMfIqpsKE2KfL3K3jeyo0jy2Uuvy6L4LV+9RQEG8f1iy5+hbLp9kspQwSBr4W+xbZNVnPmoax00a5iLngxwsiSXJ+QCDRCQSTYIoUD9fzk1tWvGBrOxp4rKbCvMEAzafY0sC5YIdnyyen3lTMzyDCIut2Kh/y3SXOUFknRYeSMpkgQ/suRBu9VnPS/8zJjyuNpkBOH+qbZTesaeMUiY+P0URkxLhgu4X6NXvkfRHmjKwrMpBwnfW/0KxBQuDq/fjS1EeJ+gpfEEXHF7l9wRYYDo+bSNyM1UwJ4AA+tLuugFsmb2RsfpUl609jHB7SuwTquSbrR+UG7BMXGTvs6sen0/9XrgL25T8rSxR//+jWrNHm6ixtVqhP31EH/huZKINDCZrrARPnSwwnrt6VfP3Lvmqe6mYqqlGmDqi2CyWoJ4ecmivhT1i0wMHdwSGKxsmDqOsnWXedihifbo8bZxDoMYICutdN8OWTsaC+MjOmgJQ4ONewiThmyGnFmhD+u8BHgWG0yzIRlCTz7mav/6YpKi4rHdyYek+KqQAdC0t9pu/zYEzIMz3X43h6TZhercMHxP62JvYfOxhe9x5DV29V0SJqRybKjaRU2FujSsMPe4EqPT05nCuuqsSpG9TINYjfwxtuebY2Hv2R/Q1vbwQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB9081.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(7916004)(396003)(39860400002)(376002)(366004)(136003)(346002)(66946007)(8676002)(4326008)(38100700002)(83380400001)(33716001)(66556008)(66476007)(316002)(6916009)(8936002)(5660300002)(9686003)(6512007)(2906002)(186003)(1076003)(6486002)(6666004)(966005)(6506007)(478600001)(86362001)(33656002)(41300700001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?esB4ZvjBCLx00oX5d+8TSC9lyYD38cUVufF9W+CT+Fz+Fj6Xtq8tJ99AjVMB?= =?us-ascii?Q?9SFasXETALBdR1AX8QVTPCEZLL+CdpE6jg4mcrSs45Ey1pTR1tzQfc68p42N?= =?us-ascii?Q?3A9fTt/ymSSiLQA8Un7GfcHDX49d8FvF4f215Qx5T9o2Z+ITYvgMufwC93JJ?= =?us-ascii?Q?dtku/f2Isoiy8q+OhBQGLT+lzApMgUiGpVQKaa2Xciq5TJ/A5MCiKsOpXsqM?= =?us-ascii?Q?2yo9AvPzuUyN3h+lyFeLiB1GuZmx2ZNCp0oKpfuQT0ugW0P/W7cOmP2nT5Kx?= =?us-ascii?Q?gAZFRWcX47uaMAnezRYwEsA2ua5/DBT6kORbeiLTioxoNgGYj0RaLXxvDn8E?= =?us-ascii?Q?IlWaCsokOW8dvr6hsht1slnO/Uwl1soO/ldqIZgQ6X95PN9lAUIO/z5DJMTn?= =?us-ascii?Q?QWJwkdT7U9KgBNXVLtzAdiq1K94bb2ULH0iws5dUfudYlKHMNF31+lOjiyG4?= =?us-ascii?Q?70oQWmnEuyzC3lukx/C+eGoqJRq7k2yLugdEn1+vNJCXHLALHM1HeqRDaszt?= =?us-ascii?Q?RCnFYoGvzUbbxerQTQttfc9QH+TgPq8Lv55Bs8rl9XnNoCDDhLjbHcaIpplh?= =?us-ascii?Q?dmg+CdBT4sIGH0jwOJsOeE227pdoDhI2Kkx6hFDyHJyprTWyAfDjlMzUhSma?= =?us-ascii?Q?6KcmtkbtUBepSZbBmuLfkvdz4CbSTuJ0qB4LldLZOm9SuNsZet1fQxLjQc9+?= =?us-ascii?Q?OTWBwVdealbsU4yB/ex5B92h53ONit4pG0j7CABTJT0UzPZBqClcIAZXanMR?= =?us-ascii?Q?a9MWgNEjbmR5EbonZqKnUFfirVuNbn157AyFRPX4S8kY9aNLLWx+e8FDak1q?= =?us-ascii?Q?HrQze0nIcP/9p016deLFLbKTfJnnsqopzzl+BZD/Yth7dYsi/wxO99JDYauy?= =?us-ascii?Q?wuSNYxT1tJaB5mOB+OnwtrgDTeIgO4lCdmBdVU3ViUyU0E7fWNBvBbx9PUDi?= =?us-ascii?Q?YimMYkKk4e5v/gFU3OJ1cFMZu7Q4GGP3JXRDKF67UCksaeHPA9Gyt/6lPC/K?= =?us-ascii?Q?nAA6yAoStSVoe7Iy34bMYmL+hSIZ90n5HmuXu/B56yDh8lB1PqSSSLe1d2zT?= =?us-ascii?Q?vUXZWtbupEuIxpE47fnu/4rcEMMNRFiekRFqnVqaonScSXG6xq48AE205dDP?= =?us-ascii?Q?KYj3jaELSM2myRY6cERhWhkJponZYTxO0csWJh85P5yHU75OGvnL2zldEvsZ?= =?us-ascii?Q?V0WvNNW1ZxCNQ3M7tGV3imLy6r8xNyDxJmrqrQxgttz6MbenetzU+aJ1BENu?= =?us-ascii?Q?ipqCe/lHFbzM0WmAF7TZCM9dJQr6UKB8eQ9HHXILH+ytwPG7uJA3+9V/pt2C?= =?us-ascii?Q?WLdljTqYtP85EJ2BtkYk0kkw3AUuDGVhJaxUHyYaA69R2ljUZG/0GUIB4yh2?= =?us-ascii?Q?5lI1IQFuaviPXQ5oDz3ptdrBOKEeMmbs9mgde+AhDfN1GusUvfa3sOVPew+G?= =?us-ascii?Q?AEXoW6Lupu0kc9nUAdysnFPKZDxGr0nl5/thfAHFYwhlrPV6jTiFRKW9OtuH?= =?us-ascii?Q?mg6aBYfKRuhc12vZiYpL+iI+bEnVHtiW0gYr1u/qhTPnygCmE2B/YkpgKYzz?= =?us-ascii?Q?bhwKEtvXG48xVMQ9ZPJ6EWs3E4l3DS9qCXGfGytsgIMQURnhuvJjbtDgnSTH?= =?us-ascii?Q?m8YS1nHVUbFpA9qIw1TD89FW2ZOdI9nxDsrftHk0ySrx?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4bf52b25-06c4-4ef5-5e5d-08da8f24df54 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9081.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 09:56:15.7132 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Sx0ld6G+NSjrQ+/MITn7o4+nW8RQOdjXhQQUiGwOZgGeznXI1iI5BzQ8XxsXE7aT X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4727 Received-SPF: pass client-ip=2a01:111:f400:7e1b::630; envelope-from=MChang@suse.com; helo=EUR05-AM6-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Sep 2022 10:01:31 -0000 On Mon, Aug 29, 2022 at 04:36:24PM +0200, Ismael Luceno wrote: > Signed-off-by: Ismael Luceno > --- > util/grub-install.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/util/grub-install.c b/util/grub-install.c > index 7b04bd3c534b..527b85e27aa7 100644 > --- a/util/grub-install.c > +++ b/util/grub-install.c > @@ -1835,6 +1835,7 @@ main (int argc, char *argv[]) > { > if (write_to_disk (ins_dev, imgfile)) > grub_util_error ("%s", _("failed to copy Grub to the PReP partition")); > + grub_set_install_backup_ponr (); This looks good to me. > } > else > { > @@ -1859,6 +1860,7 @@ main (int argc, char *argv[]) > partno = grub_dev->disk->partition > ? grub_dev->disk->partition->number + 1 : 0; > dev = grub_util_get_os_disk (grub_devices[0]); > + grub_set_install_backup_ponr (); This should be moved way up, given failure may occur at grub_make_system_path_relative_to_its_root or even earlier. But in the first place the attempt may have been wrong, given the image is installed as file in the platform directory, there we should not be botherd to set grub_set_install_backup_ponr as file should be able to be backup and restored thus is covered. On the other hand, the grub_set_install_backup_ponr looked like a workaround to me to deal with raw images embedded in partition that has no good way to restore it. That is for i386-ieee1275, /boot/grub2/i386-ieee1275/grub should be added to the list of backup and restore to get it to work in failure recovery path. Thanks, Michael > grub_install_register_ieee1275 (0, dev, > partno, relpath); > } > -- > 2.37.1 > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel