From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1oV8yM-0006ym-Ug for mharc-grub-devel@gnu.org; Mon, 05 Sep 2022 06:04:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oV8yJ-0006x4-4Z for grub-devel@gnu.org; Mon, 05 Sep 2022 06:04:51 -0400 Received: from mail-eopbgr20048.outbound.protection.outlook.com ([40.107.2.48]:49317 helo=EUR02-VE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oV8yG-0002sn-V9 for grub-devel@gnu.org; Mon, 05 Sep 2022 06:04:50 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lu4wvqbas6prOcD/L3thDl2wWfb1A0EFUm+v+B+kRHSkSIM1xLiWp3JADbo1tPVxHh0XO3lH6pD6AdceCm18VWPVAeCbZrmUsOxPtIutgD77093edKJKAgezUa1E34tQykS+1cFuQWlX30vCIVQRt3P0aPMxOZgED5fNd9v8YuaIi3L0uXfDgEkRDDk0JMSfHGj4jYEfrjxoFLEUqbI7Usr2oNr4ORRaLtZRVBsvYxRIshOrgJJumvM96DTFzcIB024wtoTGygXYAa6z4Wb8Z+ONYiSUHfrVmkqmng5oVdBJFkuRdCgs6k9nznpOUORCvcugbvXZwUBNzLmWci+PAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tRayOUhqbQrsIx0dh+R6hjoZbHWCJbTm/j8ACcvJ2AE=; b=ob+nTcNbxmvwJ7k8g82mJrBP6slpDPRcxcDiN6zG+t9RsZ9dcIhcCh9Gj+4X5e7voAPSnBQ2VHxhT4yxc0wn36ywIDI8WIrfSaamMRBRkXkiJFrVAtfTvH5pjMwNbhS1ptRdy28axpNrErKHNE9gyP4LK5qlwTrbVPg42y0ruQCu2sX4DT2EnBlwluu68CM4w4GjS7SSlM9dVp+DC6HayoooU/wRVv6Io5GWzHBAi+7k2ZfV1izQzxCEhLRIcIECXU3baKeaGMjknuoBCf8V+xtIyoJ/x1iC5Fa7YR5zeyA3gKa1DozHPC9zvWMfnczbV37SzOv1+EBMlh6ab3GMWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tRayOUhqbQrsIx0dh+R6hjoZbHWCJbTm/j8ACcvJ2AE=; b=q3cLWl6DPeftf5twABbw87P1iiO4XiWWfILK7ap3+8GnS6UOAFYrdgxC9uaqGjZbHt7wDrwtdCa6VYeKzvz/tnrEsBQbwYlwI2xmu5Lz3MoFrD30OZ7obvCGYwtuyBTtooiC1DnVZUT9qPsHpQrDg0mNc48v3m/OaD6ykKpYYaL3mBCXalm1ptc0RU1DIXhK+qNgMqmyQWQ1UTwQ1Bc6jYFyFyrHr57oEsYDx+kMV7tJ1Dqtj0Z5D4PepxnJE0o/bSq5yEdJ21Q3dyVOtKkNAxUQESSeF58YHT36mtoUeLIzb8cAUegDqhN9Fm07y5q8WLK20cDE9I3dhYmBkrMcEw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB9081.eurprd04.prod.outlook.com (2603:10a6:10:2f0::13) by DB6PR0402MB2790.eurprd04.prod.outlook.com (2603:10a6:4:97::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Mon, 5 Sep 2022 10:04:45 +0000 Received: from DU2PR04MB9081.eurprd04.prod.outlook.com ([fe80::dde8:aa4e:20d0:c5c7]) by DU2PR04MB9081.eurprd04.prod.outlook.com ([fe80::dde8:aa4e:20d0:c5c7%3]) with mapi id 15.20.5588.018; Mon, 5 Sep 2022 10:04:45 +0000 Date: Mon, 5 Sep 2022 18:04:22 +0800 From: Michael Chang To: The development of GNU GRUB Cc: Ismael Luceno Subject: Re: [PATCH v2 2/2] grub-install: Ensure a functional /dev/nvram Message-ID: <20220905100422.GB10914@mazu> References: <20220829143625.23769-1-iluceno@suse.de> <20220829143625.23769-3-iluceno@suse.de> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220829143625.23769-3-iluceno@suse.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: TYAPR01CA0104.jpnprd01.prod.outlook.com (2603:1096:404:2a::20) To DU2PR04MB9081.eurprd04.prod.outlook.com (2603:10a6:10:2f0::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 19928a40-ca30-461a-0a88-08da8f260e68 X-MS-TrafficTypeDiagnostic: DB6PR0402MB2790:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wp/ExWSmz05k3RqMJPZllXZv/6RFMRtX0mTVmS/DEsk/ZKrNckzuRJBjhcsUL1PCNhTSMBbL82OW91EsYIDuR6TgbjfHH4UqK0vQTr3NLjRmiMyX6kozBmro5HAouOtbf0Nshd2ah5Y6i2gXrrRnnkl8xTUC9qS/AhKIwqXjeRBek+w3Ft8gvVoKgIDZBCqNdAYqrp9ycCSNE8BaAgte6fEe/iS+OTbChjOt8KA2Uv6jRDeQbab3mEiDOpf2VUC2zyw3mvGzxRbw9xVRall93FeZNdnavTGHEBu/0YczeRlXrGkAPvqouXjxcge4dNR7QbDcEUom8GsL4CjK63JqfdxDWSClFQ1pqS7yh5xGZXan32+OXenKeFj7btC9t/4WO0i68ZcwAjdofjbwf8mjEZCGJ7881fHckJBn1esJYJI5XuS8cnOqZuuI0VPJMCAjqaxgmnEhrTPjKzRotN/wbuTiYCYxJgXmHu1Q/tDSpasnWdJSNjZRht9jok54VvjN+GC4S/UnsRR/HjdwAPceK/o219/rkPBi7G4w9bQJwSs5nIsHKz3qGb4MfNtNBP379E9auhn6JFESIKkfJbDsAx19KVeSXF4JbZh1hDyVqjqCuO9SKjs3zrfslKBBiO53vLzMcgmCfo88kVC4ob7Uyq0D0tOVK6n+g7yBO+mjOXD7VobLRqZ8Eb/JGNfyGja5forTO3xp+pnW8dRG+ddZidnRrDPNKpjzyfAFQUvNKrA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB9081.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(7916004)(366004)(39860400002)(396003)(376002)(346002)(136003)(316002)(5660300002)(33716001)(6916009)(38100700002)(41300700001)(6486002)(8936002)(966005)(86362001)(6506007)(1076003)(8676002)(9686003)(6512007)(4326008)(66556008)(66476007)(2906002)(478600001)(33656002)(6666004)(66946007)(186003)(83380400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?402KPBTK+cA5IyOiNKhyuPDnO7orywnsROyB9iSYS+LjzMxA/WwpAxbu29PZ?= =?us-ascii?Q?FdF5k2C8XkR4Ciw/hljq1YuoYJanDEkN2dGECX0u9LIQfLgTnpqJ+5vAlInV?= =?us-ascii?Q?3sPYbh8KSSroqKExwDcL8aTVD+qecBxp2g/+L1S3ISAZC6m2gRPaquS9xIXG?= =?us-ascii?Q?Ml56nVvyQGD3ax5PHLVOFTR7WfXzgEEt34tKQIRVJX1wb8lW13WVhWeC4unT?= =?us-ascii?Q?EQn/Tjm7UUsy/Xcs3EmxoDVf+uWcRKHIFeZo6ZW4l3RQjzqYvMvzX7J4KlGl?= =?us-ascii?Q?WCqctNL03/XN7nOxyHv27V3esQ63+ujre1PpSeGz8e+JjzUbetfCWOJjJrxa?= =?us-ascii?Q?E8P5XM0Z9WZQK8RhKkFJGwMFJlZJlcAVqRiFb7EQ4OmsHsGi4oGqq6zDzUmv?= =?us-ascii?Q?hA9BJFjKzw+mDwVeh8mqBBylesGmnQhybLlFP9ytdb7+atvv2qhzSyh1T3Jr?= =?us-ascii?Q?+bTV4GuXYgOcdJpgSFRy5SXFgkb8lMPDUuOSFm77a8+QQC1nuHS3WQEezCy9?= =?us-ascii?Q?8lVyKqDqYbRLXixA8A/WctIE+qa3mb+UOAt0ulG8re7xqv4Jz2EleOBpG9u7?= =?us-ascii?Q?74HKd/GwZTEnd0zUWSzxNNMtd+IuASlJZbKkM0+NZifQgthy9jyZ4CWrFN3S?= =?us-ascii?Q?1vrzg/0u3+JG9jcpwaGDSaSqgWshurTvEZCKmfB9ifGutsJS4M+qBNPbfJZ1?= =?us-ascii?Q?/bVWIdte++qP+80bZVE0NSTA3Ib+fhxR2XsdYirmdJScX/KZpS/D6aYMPmXE?= =?us-ascii?Q?Iq0rkCOFG8oENYxeR6yYPYV5iN+ZvpeCbwE4Jkx/bNPeqBTiAOBBidQY5Tkm?= =?us-ascii?Q?nTZ4Y3fZSnq3rZR3ye9CJMupVPLAfB0D/PAz+NSdf4p4fzjXsKQKDQdwZLmF?= =?us-ascii?Q?A/dfRitiH2rWidfE5iFBh85ovddXpNKZ7uMNWw9ySeX5AYAmmVDE0qx9utPY?= =?us-ascii?Q?2vtZ2c04pyQHX+KhWAGAUAE6BvAbbv4mRXhfO1vsaKr+wVj/LR+z4Dq+g0vY?= =?us-ascii?Q?JDyjGKj/2NecBtjJHqkfrLXgGfk+Zb7ANzYoDUcu0WYJ0YP5ZsV2pyth5HPB?= =?us-ascii?Q?sdAZY1Jm4aQuqVy9hcSaRH0Jyi2A25nqWgDmO2hfLGGFOTZG8t7vZlV3uEUw?= =?us-ascii?Q?6q8lZkAIp1q0CV8GycaK1M2/K4+AdbjDcJ7N6RF0W8I7F1R7CzoO+WGT+HkU?= =?us-ascii?Q?mn1stYmEu8XFKQGBZ8qwnOli65eJkWJT5CadEdf4dORehkfjIH1+wL5Tz+hO?= =?us-ascii?Q?sXgcBzHR91xVOY8iDrZh85JsGWdldVBgANXQeeBmesDj0nzy/UI97nWo2X4I?= =?us-ascii?Q?I+bFwsnGZSl/CjtENcGGqattQKyZ9A8g87K9HBg+dY1ieu6hkts4Ikp3fosm?= =?us-ascii?Q?4MTW3F60isXj2JWwWBnUysTh8uHmb70E+OuBc2FxFXXvJVI7dOWyEGJq+QCx?= =?us-ascii?Q?gmJlPMjeXnC0ZgRS8vDn5H6xocPZSl0r96O04gxzEELBNR99xIhpJLwzdKMo?= =?us-ascii?Q?jWLTb9wzIQNMcoLu219qh3HL/WII1NwT2IZfG46ACJJE4QM71vl6QvpnrDTY?= =?us-ascii?Q?ue7jz//JbezCRp01smpucNp87e1zCLG9GgO7kuTaXK5aOPuBwGzChmr1r3ge?= =?us-ascii?Q?pYp4EVDpY02jJpsvDq4QPEPMQvqzBiiyRVsxfo4662pO?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19928a40-ca30-461a-0a88-08da8f260e68 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9081.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 10:04:44.9384 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y6sviXEn+O0/hBELs+X4IVhs7SdzD9EF4UmcJQJc69nPDx+X2FSWwaqbxIO2cfNA X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2790 Received-SPF: pass client-ip=40.107.2.48; envelope-from=MChang@suse.com; helo=EUR02-VE1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Sep 2022 10:04:51 -0000 On Mon, Aug 29, 2022 at 04:36:25PM +0200, Ismael Luceno wrote: > This enables an early failure; for i386-ieee1275 and powerpc-ieee1275 on > Linux, without /dev/nvram the system may be left in an unbootable state. > > Signed-off-by: Ismael Luceno > --- > util/grub-install.c | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/util/grub-install.c b/util/grub-install.c > index 527b85e27aa7..c84a2fb0526f 100644 > --- a/util/grub-install.c > +++ b/util/grub-install.c > @@ -827,6 +827,16 @@ fill_core_services (const char *core_services) > free (sysv_plist); > } > > +static void > +try_open (const char *path) > +{ > + FILE *f; > + f = grub_util_fopen (path, "r+"); > + if (!f) > + grub_util_error (_("Unable to open %s: %s"), path, strerror(errno)); > + fclose (f); > +} > + > int > main (int argc, char *argv[]) > { > @@ -1026,6 +1036,19 @@ main (int argc, char *argv[]) > break; > } > > + switch (platform) > + { > + case GRUB_INSTALL_PLATFORM_I386_IEEE1275: > + case GRUB_INSTALL_PLATFORM_POWERPC_IEEE1275: > +#ifdef __linux__ > + /* On Linux, ensure /dev/nvram is _functional_. */ > + try_open ("/dev/nvram"); The update_nvram variable should be tested in case user has skipped it. Thanks, Michael > +#endif > + break; > + default: > + break; > + } > + > /* Find the EFI System Partition. */ > > if (is_efi) > -- > 2.37.1 > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel