From: "zhongling0719@126.com" <zhongling0719@126.com>
To: "stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
"zenghongling@kylinos.cn" <zenghongling@kylinos.cn>
Cc: "Greg KH" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"usb-storage@lists.one-eyed-alien.net"
<usb-storage@lists.one-eyed-alien.net>
Subject: Re: Re: [PATCH v2 1/3] uas: add no-uas quirk for Hiksemi usb_disk
Date: Thu, 8 Sep 2022 06:59:09 +0800 [thread overview]
Message-ID: <2022090806580941868521@126.com> (raw)
In-Reply-To: YxjRna/qihbKPEge@rowland.harvard.edu
Sorry, My git send-email suddly can't send patch,
I will fix this problem as soon as possible and send it to you
Thanks!
zhongling0719@126.com
From: Alan Stern
Date: 2022-09-08 01:15
To: Hongling Zeng
CC: gregkh; linux-usb; usb-storage; zhongling0719
Subject: Re: [PATCH v2 1/3] uas: add no-uas quirk for Hiksemi usb_disk
On Wed, Sep 07, 2022 at 10:54:06AM +0800, Hongling Zeng wrote:
> The UAS mode of Hiksemi is reported to fail to work on several platforms
> with the following error message, then after re-connecting the device will
> be offlined and not working at all.
>
> [ 592.518442][ 2] sd 8:0:0:0: [sda] tag#17 uas_eh_abort_handler 0 uas-tag 18
> inflight: CMD
> [ 592.527575][ 2] sd 8:0:0:0: [sda] tag#17 CDB: Write(10) 2a 00 03 6f 88 00 00
> 04 00 00
> [ 592.536330][ 2] sd 8:0:0:0: [sda] tag#0 uas_eh_abort_handler 0 uas-tag 1
> inflight: CMD
> [ 592.545266][ 2] sd 8:0:0:0: [sda] tag#0 CDB: Write(10) 2a 00 07 44 1a 88 00
> 00 08 00
>
> These disks have a broken uas implementation, the tag field of the status
> iu-s is not set properly,so we need to fall-back to usb-storage.
>
> Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn>
> ---
> change for v1
> -Change the email real name
>
> Change for v2
> -Change spelling error
>
> ---
> drivers/usb/storage/unusual_uas.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
> index cdff7dc..a6bf87a 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -62,6 +62,13 @@ UNUSUAL_DEV(0x059f, 0x1061, 0x0000, 0x9999,
> USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> US_FL_IGNORE_UAS),
>
> +/* Reported-by: Hongling Zeng <zenghongling@kylinos.cn> */
> +UNUSUAL_DEV(0x090c, 0x2000, 0x0000, 0x9999,
> + "Hiksemi",
> + "External HDD",
> + USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> + US_FL_IGNORE_UAS),
> +
> /*
> * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI
> * commands in UAS mode. Observed with the 1.28 firmware; are there others?
Acked-by: Alan Stern <stern@rowland.harvard.edu>
I didn't receive v2 of the 2/3 patch. Did you forget to send it?
Alan Stern
prev parent reply other threads:[~2022-09-07 23:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 2:54 [PATCH v2 1/3] uas: add no-uas quirk for Hiksemi usb_disk Hongling Zeng
2022-09-07 17:15 ` Alan Stern
2022-09-07 22:59 ` zhongling0719 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2022090806580941868521@126.com \
--to=zhongling0719@126.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
--cc=zenghongling@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.