From: Dmitry Bogdanov <d.bogdanov@yadro.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Martin Petersen <martin.petersen@oracle.com>,
<target-devel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<linux@yadro.com>
Subject: Re: [PATCH 1/4] target: core: fix preempt and abort for allreg res
Date: Thu, 8 Sep 2022 11:34:48 +0300 [thread overview]
Message-ID: <20220908083448.GA9218@yadro.com> (raw)
In-Reply-To: <196c8254-1dcb-1fcf-d746-0bf3a4c12ff4@acm.org>
On Wed, Sep 07, 2022 at 09:18:57AM -0700, Bart Van Assche wrote:
>
> On 9/7/22 06:58, Dmitry Bogdanov wrote:
> > - if (pr_reg->pr_res_key != sa_res_key)
> > + if ((sa_res_key) && (pr_reg->pr_res_key != sa_res_key))
> > continue;
>
> Please do not introduce superfluous parentheses. Four parentheses can be
> left out from the above code without affecting readability.
Ok, will remove.
BR,
Dmitry
next prev parent reply other threads:[~2022-09-08 8:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 13:58 [PATCH 0/4] target: fix bugs in Persistent Reservations Dmitry Bogdanov
2022-09-07 13:58 ` [PATCH 1/4] target: core: fix preempt and abort for allreg res Dmitry Bogdanov
2022-09-07 16:18 ` Bart Van Assche
2022-09-08 8:34 ` Dmitry Bogdanov [this message]
2022-09-07 13:58 ` [PATCH 2/4] target: core: fix memory leak in preempt_and_abort Dmitry Bogdanov
2022-09-07 13:58 ` [PATCH 3/4] target: core: abort all preempted regs if requested Dmitry Bogdanov
2022-09-07 13:58 ` [PATCH 4/4] target: core: new key must be used for moved PR Dmitry Bogdanov
2022-09-07 16:19 ` Bart Van Assche
2022-09-08 8:39 ` Dmitry Bogdanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220908083448.GA9218@yadro.com \
--to=d.bogdanov@yadro.com \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=martin.petersen@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.