From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CDF7C38145 for ; Thu, 8 Sep 2022 15:21:23 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AB0561718; Thu, 8 Sep 2022 17:20:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AB0561718 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1662650481; bh=B/jrAwaqTIVAHH/NRTStFlo4nPktzG4m8t2fU/E3MfM=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MRH1vC4cLUR10pznTdCzgibGTW4B5otNPOgzTyJH94ifoAVfSeHw/XleyJ013R7HE dVpaCZ4Uq9PJAymQyQIeJFEQLx916OkxNmVjwBMunTPJm8ZfS29O7o8FPWRqjOAN5D +RcHvGatN236yQWyW8JnSmttO7CU4pVWvNFouzRg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 49F54F801F7; Thu, 8 Sep 2022 17:20:31 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8476FF80217; Thu, 8 Sep 2022 17:20:30 +0200 (CEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 931AFF8011C for ; Thu, 8 Sep 2022 17:20:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 931AFF8011C Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="VIWvkQc2" Received: from booty (unknown [77.244.183.192]) (Authenticated sender: luca.ceresoli@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 49192E0008; Thu, 8 Sep 2022 15:20:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1662650422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OaycjTCUtVL0XC/TXiHrCS9tTq4CU4MjnzsvbA4dKO4=; b=VIWvkQc2rLTZkRlB9Caja28dMM3gG2XlRofkwI6AWfSSz/kNwH9bBu5kYOe2dhlaUX6AUr i0zh5Hupq8g2tAOoEIgXWAGNC6fNDVOpBHIsqHe3D+pNeF5DYgLbQjZ3fjb5OZKomKIwzH o+LLDo2w8HoVJzR2NgTDT3/s7i2PbSm59OayUUbmD6V5YUkwefuyjr8Y0AVtfNDJ1H52il 2tao+VNyOicFrt3Ina7RBvn3rx62qM8sFk4gczmzLz8HOqDP6AMKVsnTzIJe+R7GCXTl1V ckAUtcllF0oofsFKMSXc1eMv2fvadLHH9kzV26ap8xmDhgcd1YSQwdPb95B4tQ== Date: Thu, 8 Sep 2022 17:20:16 +0200 From: Luca Ceresoli To: Krzysztof Kozlowski Subject: Re: [PATCH 2/8] ASoC: rockchip: rk3308: add audio card bindings Message-ID: <20220908172016.6e23df8c@booty> In-Reply-To: References: <20220907142124.2532620-1-luca.ceresoli@bootlin.com> <20220907142124.2532620-3-luca.ceresoli@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Heiko Stuebner , Takashi Iwai , Chris Morgan , Liam Girdwood , Rob Herring , linux-kernel@vger.kernel.org, Nicolas Frattaroli , linux-rockchip@lists.infradead.org, Mark Brown , Krzysztof Kozlowski , Philipp Zabel , Johan Jonker , linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hello Krzysztof, thank you for reviewing my patches. On Thu, 8 Sep 2022 13:49:34 +0200 Krzysztof Kozlowski wrote: > On 07/09/2022 16:21, luca.ceresoli@bootlin.com wrote: > > From: Luca Ceresoli [...] > > +properties: > > + compatible: > > + const: rockchip,rk3308-audio-graph-card > > Is "graph" part of device name or you just put it there because of other > schema? Indeed this comes from the "audio-graph-card" compatible string. > The compatible should reflect the device name, not some other > pieces in Linux or in bindings. Would it be OK to rename it to rockchip,rk3308-audio-card (i.e. drop the "graph-" infix)? Fixes for the other comments you made to this and the other patches are already queued for v2. Best regards, Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E92D5C38145 for ; Thu, 8 Sep 2022 15:33:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wn41mgB05D7H0y8PIasrORAQUXP5W3opq/QUAt269zc=; b=U1xhfrR1kHkonc GZ/q3LxLogxU2gjXzE9IdMyPYqb82397+3BgMmB9EhfnpB0G5V7bSoszmL1UjOIJ062R9jhU2Rj2s YHjkmAmlA51JqlC4ZGjolLeDISuKhQRadFqyKiRwixgQFFXfcNTWe0tBfy930HmxqYoidO6mpSqDc 8HGAsjd7rMxPodTSBSs2NwArEXIH+7zIxMGiVNNVVuHio8KWYhDixwkkacLpxRr1BMxL3flxRNTHX zeBHr4BeZmJk6KqVCZ3Ztm/rPHkXgFwvEKjFYielMVT2lGKHaPn8YNGQQlHZekEvdV8QEJ42Vchoq 90pOqgcAdbPomuYwA1dg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWJWU-005FeO-Qk; Thu, 08 Sep 2022 15:32:58 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWJKP-0058cd-Gc; Thu, 08 Sep 2022 15:20:31 +0000 Received: from booty (unknown [77.244.183.192]) (Authenticated sender: luca.ceresoli@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 49192E0008; Thu, 8 Sep 2022 15:20:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1662650422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OaycjTCUtVL0XC/TXiHrCS9tTq4CU4MjnzsvbA4dKO4=; b=VIWvkQc2rLTZkRlB9Caja28dMM3gG2XlRofkwI6AWfSSz/kNwH9bBu5kYOe2dhlaUX6AUr i0zh5Hupq8g2tAOoEIgXWAGNC6fNDVOpBHIsqHe3D+pNeF5DYgLbQjZ3fjb5OZKomKIwzH o+LLDo2w8HoVJzR2NgTDT3/s7i2PbSm59OayUUbmD6V5YUkwefuyjr8Y0AVtfNDJ1H52il 2tao+VNyOicFrt3Ina7RBvn3rx62qM8sFk4gczmzLz8HOqDP6AMKVsnTzIJe+R7GCXTl1V ckAUtcllF0oofsFKMSXc1eMv2fvadLHH9kzV26ap8xmDhgcd1YSQwdPb95B4tQ== Date: Thu, 8 Sep 2022 17:20:16 +0200 From: Luca Ceresoli To: Krzysztof Kozlowski Cc: alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Jaroslav Kysela , Takashi Iwai , Nicolas Frattaroli , Philipp Zabel , Johan Jonker , Chris Morgan Subject: Re: [PATCH 2/8] ASoC: rockchip: rk3308: add audio card bindings Message-ID: <20220908172016.6e23df8c@booty> In-Reply-To: References: <20220907142124.2532620-1-luca.ceresoli@bootlin.com> <20220907142124.2532620-3-luca.ceresoli@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220908_082029_908010_A0984FF4 X-CRM114-Status: GOOD ( 12.59 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hello Krzysztof, thank you for reviewing my patches. On Thu, 8 Sep 2022 13:49:34 +0200 Krzysztof Kozlowski wrote: > On 07/09/2022 16:21, luca.ceresoli@bootlin.com wrote: > > From: Luca Ceresoli [...] > > +properties: > > + compatible: > > + const: rockchip,rk3308-audio-graph-card > > Is "graph" part of device name or you just put it there because of other > schema? Indeed this comes from the "audio-graph-card" compatible string. > The compatible should reflect the device name, not some other > pieces in Linux or in bindings. Would it be OK to rename it to rockchip,rk3308-audio-card (i.e. drop the "graph-" infix)? Fixes for the other comments you made to this and the other patches are already queued for v2. Best regards, Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F67DC54EE9 for ; Thu, 8 Sep 2022 15:33:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mSfloLP0XIrfXUwZZ/CQwurxUg20NI/ky7/uc3TdRLc=; b=TvTNUCweY5aRQH ZLpDV24b5Wr6fDJ/p7CWrOf6G/LXWsLnjgF/TlexNGsBIXSfmtPPZdZcQNt6nTPj5kc2n3KyaWdM7 aG2r7XKfdW9EgY3RrPgaMhrMeVgzeGUMSUZC7XwsqJmlyJlFY95/vufbNa67nvjZ+bK4kZkvQ4PUO 793b3oQb8E+gxGVYKxaBy6mi/25OtaKKAOSeRfidC7gyYnWeOx2W09pvycrhlr1nXrC1IIqs4fjAm 4y5EjggjM30R6JLuXpfVFCF37+uYaSXbRctiDJhxVMIYyZzvX4xV3u5W93+lQzwf3rX3l2VR685x0 Y+2PUS7K5i66mD0pxIBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWJVl-005F90-56; Thu, 08 Sep 2022 15:32:14 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWJKP-0058cd-Gc; Thu, 08 Sep 2022 15:20:31 +0000 Received: from booty (unknown [77.244.183.192]) (Authenticated sender: luca.ceresoli@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 49192E0008; Thu, 8 Sep 2022 15:20:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1662650422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OaycjTCUtVL0XC/TXiHrCS9tTq4CU4MjnzsvbA4dKO4=; b=VIWvkQc2rLTZkRlB9Caja28dMM3gG2XlRofkwI6AWfSSz/kNwH9bBu5kYOe2dhlaUX6AUr i0zh5Hupq8g2tAOoEIgXWAGNC6fNDVOpBHIsqHe3D+pNeF5DYgLbQjZ3fjb5OZKomKIwzH o+LLDo2w8HoVJzR2NgTDT3/s7i2PbSm59OayUUbmD6V5YUkwefuyjr8Y0AVtfNDJ1H52il 2tao+VNyOicFrt3Ina7RBvn3rx62qM8sFk4gczmzLz8HOqDP6AMKVsnTzIJe+R7GCXTl1V ckAUtcllF0oofsFKMSXc1eMv2fvadLHH9kzV26ap8xmDhgcd1YSQwdPb95B4tQ== Date: Thu, 8 Sep 2022 17:20:16 +0200 From: Luca Ceresoli To: Krzysztof Kozlowski Cc: alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Jaroslav Kysela , Takashi Iwai , Nicolas Frattaroli , Philipp Zabel , Johan Jonker , Chris Morgan Subject: Re: [PATCH 2/8] ASoC: rockchip: rk3308: add audio card bindings Message-ID: <20220908172016.6e23df8c@booty> In-Reply-To: References: <20220907142124.2532620-1-luca.ceresoli@bootlin.com> <20220907142124.2532620-3-luca.ceresoli@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220908_082029_908010_A0984FF4 X-CRM114-Status: GOOD ( 12.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Krzysztof, thank you for reviewing my patches. On Thu, 8 Sep 2022 13:49:34 +0200 Krzysztof Kozlowski wrote: > On 07/09/2022 16:21, luca.ceresoli@bootlin.com wrote: > > From: Luca Ceresoli [...] > > +properties: > > + compatible: > > + const: rockchip,rk3308-audio-graph-card > > Is "graph" part of device name or you just put it there because of other > schema? Indeed this comes from the "audio-graph-card" compatible string. > The compatible should reflect the device name, not some other > pieces in Linux or in bindings. Would it be OK to rename it to rockchip,rk3308-audio-card (i.e. drop the "graph-" infix)? Fixes for the other comments you made to this and the other patches are already queued for v2. Best regards, Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9AA1C38145 for ; Thu, 8 Sep 2022 15:20:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232267AbiIHPUh (ORCPT ); Thu, 8 Sep 2022 11:20:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232113AbiIHPUa (ORCPT ); Thu, 8 Sep 2022 11:20:30 -0400 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44689564CD; Thu, 8 Sep 2022 08:20:25 -0700 (PDT) Received: from booty (unknown [77.244.183.192]) (Authenticated sender: luca.ceresoli@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 49192E0008; Thu, 8 Sep 2022 15:20:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1662650422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OaycjTCUtVL0XC/TXiHrCS9tTq4CU4MjnzsvbA4dKO4=; b=VIWvkQc2rLTZkRlB9Caja28dMM3gG2XlRofkwI6AWfSSz/kNwH9bBu5kYOe2dhlaUX6AUr i0zh5Hupq8g2tAOoEIgXWAGNC6fNDVOpBHIsqHe3D+pNeF5DYgLbQjZ3fjb5OZKomKIwzH o+LLDo2w8HoVJzR2NgTDT3/s7i2PbSm59OayUUbmD6V5YUkwefuyjr8Y0AVtfNDJ1H52il 2tao+VNyOicFrt3Ina7RBvn3rx62qM8sFk4gczmzLz8HOqDP6AMKVsnTzIJe+R7GCXTl1V ckAUtcllF0oofsFKMSXc1eMv2fvadLHH9kzV26ap8xmDhgcd1YSQwdPb95B4tQ== Date: Thu, 8 Sep 2022 17:20:16 +0200 From: Luca Ceresoli To: Krzysztof Kozlowski Cc: alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Jaroslav Kysela , Takashi Iwai , Nicolas Frattaroli , Philipp Zabel , Johan Jonker , Chris Morgan Subject: Re: [PATCH 2/8] ASoC: rockchip: rk3308: add audio card bindings Message-ID: <20220908172016.6e23df8c@booty> In-Reply-To: References: <20220907142124.2532620-1-luca.ceresoli@bootlin.com> <20220907142124.2532620-3-luca.ceresoli@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello Krzysztof, thank you for reviewing my patches. On Thu, 8 Sep 2022 13:49:34 +0200 Krzysztof Kozlowski wrote: > On 07/09/2022 16:21, luca.ceresoli@bootlin.com wrote: > > From: Luca Ceresoli [...] > > +properties: > > + compatible: > > + const: rockchip,rk3308-audio-graph-card > > Is "graph" part of device name or you just put it there because of other > schema? Indeed this comes from the "audio-graph-card" compatible string. > The compatible should reflect the device name, not some other > pieces in Linux or in bindings. Would it be OK to rename it to rockchip,rk3308-audio-card (i.e. drop the "graph-" infix)? Fixes for the other comments you made to this and the other patches are already queued for v2. Best regards, Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com