From: Greg Kurz <groug@kaod.org>
To: Linus Heckemann <git@sphalerite.org>
Cc: qemu-devel@nongnu.org,
"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
Qemu-block <qemu-block@nongnu.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v3] 9pfs: use GHashTable for fid table
Date: Thu, 8 Sep 2022 18:14:17 +0200 [thread overview]
Message-ID: <20220908181417.781ae1f4@bahia> (raw)
In-Reply-To: <ygaillx6e4r.fsf@localhost>
On Thu, 08 Sep 2022 18:10:28 +0200
Linus Heckemann <git@sphalerite.org> wrote:
> (sorry for the dup @Greg, forgot to reply-all)
>
> Greg Kurz <groug@kaod.org> writes:
> >> > g_hash_table_steal_extended() [1] actually allows to do just that.
> >>
> >> g_hash_table_steal_extended unfortunately isn't available since it was
> >> introduced in glib 2.58 and we're maintaining compatibility to 2.56.
> >>
> >
> > Ha... this could be addressed through conditional compilation, e.g.:
>
> It still won't compile, because we set GLIB_VERSION_MAX_ALLOWED in
> glib-compat.h and it would require a compat wrapper as described
ah drat, you're right !
> there. I think that's a bit much for this far more marginal performance
> change. I'm happy to resubmit with the TODO comment though if you like?
Either that or Christian may add it when merging.
Cheers,
--
Greg
next prev parent reply other threads:[~2022-09-08 16:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 11:23 [PATCH v3] 9pfs: use GHashTable for fid table Linus Heckemann
2022-09-08 12:18 ` Greg Kurz
2022-09-08 16:10 ` Linus Heckemann
2022-09-08 16:14 ` Greg Kurz [this message]
2022-09-09 13:10 ` Christian Schoenebeck
2022-09-19 17:34 ` Christian Schoenebeck
2022-09-22 11:43 ` Linus Heckemann
2022-09-22 13:24 ` Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220908181417.781ae1f4@bahia \
--to=groug@kaod.org \
--cc=berrange@redhat.com \
--cc=f4bug@amsat.org \
--cc=git@sphalerite.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.