From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E84C439C for ; Thu, 8 Sep 2022 22:32:49 +0000 (UTC) Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-11e9a7135easo48271049fac.6 for ; Thu, 08 Sep 2022 15:32:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=CxueroWKOCf1VlWz/nI3gMCK0OJff9cC2ODwmgYrqaM=; b=o6SNo2Dy+bhObc4GAvXhDmgiGniuP60CntFLrnH5kB4WT5of1yZkZkhihIMMnO7Dex Spf/KDSQEH1AvXA2rlLh/rvOy+ItfdUjAJmy0UdaHrr0mp6haaeoPMAGoKaUt/lPDipa 1JZ4u5eZ5B479ZFVRqrZN4CwX6tK85d2ijYEmEeYr73v+1Rg7KqeZuYUtOCeypnjKSCi NwwN9WHxjSYKicBnCljfYW9DEeSftgtHRAkh8jlJnfGtxIPJ8OEpCqNmvqM6Mby0Pedc QhmYCmnRd3eevqv6y2D96+dK2K/zDAXDvJPInPEsotKldUw3A3Ii6E5XWBKyz/HjmRaf KthA== X-Gm-Message-State: ACgBeo2jkZBYq2fKKPq6LsruR30Xj1RSQFhn4MDiBgdRnlUzg8cWGr4K 9Fa6HcwiP+Vu8lk7Prosdg== X-Google-Smtp-Source: AA6agR5MC+RLWyuYmH/6MzXRA1Lyj+OMmMzdoCAZCKC3Rql+zmp3AUsEWYhhK37k+JRJFRvkiePTpw== X-Received: by 2002:a05:6870:6317:b0:10e:631c:5e63 with SMTP id s23-20020a056870631700b0010e631c5e63mr3459441oao.262.1662676369003; Thu, 08 Sep 2022 15:32:49 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id 3-20020a4a1b03000000b00441c26f8fadsm723780oop.12.2022.09.08.15.32.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 15:32:48 -0700 (PDT) Received: (nullmailer pid 3461521 invoked by uid 1000); Thu, 08 Sep 2022 22:32:47 -0000 Date: Thu, 8 Sep 2022 17:32:47 -0500 From: Rob Herring To: Thierry Reding Cc: Joerg Roedel , Will Deacon , Robin Murphy , Nicolin Chen , Krishna Reddy , Dmitry Osipenko , Alyssa Rosenzweig , Janne Grunau , Sameer Pujar , devicetree@vger.kernel.org, iommu@lists.linux-foundation.org, linux-tegra@vger.kernel.org, asahi@lists.linux.dev Subject: Re: [PATCH v8 1/5] dt-bindings: reserved-memory: Document iommu-addresses Message-ID: <20220908223247.GA3448766-robh@kernel.org> References: <20220905170833.396892-1-thierry.reding@gmail.com> <20220905170833.396892-2-thierry.reding@gmail.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220905170833.396892-2-thierry.reding@gmail.com> On Mon, Sep 05, 2022 at 07:08:29PM +0200, Thierry Reding wrote: > From: Thierry Reding > > This adds the "iommu-addresses" property to reserved-memory nodes, which > allow describing the interaction of memory regions with IOMMUs. Two use- > cases are supported: > > 1. Static mappings can be described by pairing the "iommu-addresses" > property with a "reg" property. This is mostly useful for adopting > firmware-allocated buffers via identity mappings. One common use- > case where this is required is if early firmware or bootloaders > have set up a bootsplash framebuffer that a display controller is > actively scanning out from during the operating system boot > process. > > 2. If an "iommu-addresses" property exists without a "reg" property, > the reserved-memory node describes an IOVA reservation. Such memory > regions are excluded from the IOVA space available to operating > system drivers and can be used for regions that must not be used to > map arbitrary buffers. > > Each mapping or reservation is tied to a specific device via a phandle > to the device's device tree node. This allows a reserved-memory region > to be reused across multiple devices. > > Signed-off-by: Thierry Reding > --- > Changes in v8: > - include validation warning fixes that had crept into an unrelated patch > > Changes in v7: > - keep reserved-memory.txt to avoid broken references > > Changes in v6: > - add device phandle to iommu-addresses property in examples > - remove now unused dt-bindings/reserved-memory.h header > > .../reserved-memory/reserved-memory.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) Thanks for being persistent with this. It looks good to me. Reviewed-by: Rob Herring I really don't like new common bindings with only 1 user, so I hope the Asahi folks chime in here. Or really anyone else look at it. Rob