From: Alex Williamson <alex.williamson@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: John Hubbard <jhubbard@nvidia.com>,
David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
linux-kernel@vger.kernel.org, Jason Gunthorpe <jgg@nvidia.com>
Subject: Re: [GIT PULL] VFIO fix for v6.0-rc5
Date: Fri, 9 Sep 2022 06:08:32 -0600 [thread overview]
Message-ID: <20220909060832.17f6607f.alex.williamson@redhat.com> (raw)
In-Reply-To: <CAHk-=wj3rrkPvPJB_u4qoHK4=PVUuBHKB67f_oZO62EE22pNPQ@mail.gmail.com>
On Fri, 9 Sep 2022 07:53:17 -0400
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Fri, Sep 9, 2022 at 6:52 AM Alex Williamson
> <alex.williamson@redhat.com> wrote:
> >
> > VFIO fix for v6.0-rc5
> >
> > - Fix zero page refcount leak (Alex Williamson)
>
> Ugh. This is disgusting.
>
> Don't get me wrong - I've pulled this, but I think there's some deeper
> problem that made this patch required.
>
> Why is pin_user_pages_remote() taking a reference to a reserved page?
> Maybe it just shouldn't (and then obviously we should fix the unpin
> case to match too).
>
> Adding a few GUP people to the participants for comments.
>
> Anybody?
Yes, David is working on allocating pages rather than pinning the zero
page, however that's going to have some user visible locked memory
accounting changes. This isn't the long term solution, it's only meant
to close the shared zero page refcount holes we have currently. Thanks,
Alex
next prev parent reply other threads:[~2022-09-09 12:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 10:52 [GIT PULL] VFIO fix for v6.0-rc5 Alex Williamson
2022-09-09 11:53 ` Linus Torvalds
2022-09-09 12:02 ` David Hildenbrand
2022-09-09 18:58 ` John Hubbard
2022-09-09 12:08 ` Alex Williamson [this message]
2022-09-09 14:31 ` Jason Gunthorpe
2022-09-09 11:59 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220909060832.17f6607f.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.