From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5734ECAAD3 for ; Fri, 9 Sep 2022 14:58:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231405AbiIIO6x (ORCPT ); Fri, 9 Sep 2022 10:58:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231164AbiIIO6n (ORCPT ); Fri, 9 Sep 2022 10:58:43 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A8C813883F for ; Fri, 9 Sep 2022 07:58:43 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 9A38A68AA6; Fri, 9 Sep 2022 16:58:39 +0200 (CEST) Date: Fri, 9 Sep 2022 16:58:39 +0200 From: Christoph Hellwig To: Christian Brauner Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, Seth Forshee Subject: Re: [PATCH 3/6] acl: add vfs_set_acl_prepare() Message-ID: <20220909145839.GA11530@lst.de> References: <20220829123843.1146874-1-brauner@kernel.org> <20220829123843.1146874-4-brauner@kernel.org> <20220906045746.GB32578@lst.de> <20220906074532.ysyitr5yxy5adfsx@wittgenstein> <20220906075313.GA6672@lst.de> <20220906080744.3ielhtvqdpbqbqgq@wittgenstein> <20220906081510.GA8363@lst.de> <20220906082428.mfcjily4dyefunds@wittgenstein> <20220909080339.2rdbbk2g2p5evznd@wittgenstein> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220909080339.2rdbbk2g2p5evznd@wittgenstein> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Sep 09, 2022 at 10:03:39AM +0200, Christian Brauner wrote: > This passes xfstests (ext4, xfs, btrfs, overlayfs with and without > idmapped layers, and LTP). I only needed to add i_op->get_dentry_acl() > as it was possible to adapt ->set_acl() to take a dentry argument and > not an inode argument. This looks pretty nice. Two high level comments: - instead of adding lots of stub ->get_dentry_acl Ń–mplementations that wrap ->get_acl, just call ->get_acl if ->get_dentry_acl is not implementet in the VFS - I think the methods that take a dentry should be named consisently, so either ->get_dentry_acl and ->get_dentry_acl vs ->get_acl, or ->get_acl and ->set_acl vs ->get_inode_acl or something like that.