From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Louis Aussedat <aussedat.louis@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/rtl8189es: fix build failure due to missing Linux options
Date: Sun, 11 Sep 2022 22:18:56 +0200 [thread overview]
Message-ID: <20220911201856.GK898622@scaer> (raw)
In-Reply-To: <20220911195724.3296064-1-giulio.benetti@benettiengineering.com>
Giulio, All,
On 2022-09-11 21:57 +0200, Giulio Benetti spake thusly:
> This driver requires CONFIG_CFG80211 and CONFIG_MMC to build so let's add
> them to RTL8189ES_LINUX_CONFIG_FIXUPS.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/rtl8189es/rtl8189es.mk | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/package/rtl8189es/rtl8189es.mk b/package/rtl8189es/rtl8189es.mk
> index 51477ccc97..a283852a11 100644
> --- a/package/rtl8189es/rtl8189es.mk
> +++ b/package/rtl8189es/rtl8189es.mk
> @@ -13,5 +13,10 @@ RTL8189ES_MODULE_MAKE_OPTS = \
> KVER=$(LINUX_VERSION_PROBED) \
> KSRC=$(LINUX_DIR)
>
> +define RTL8189ES_LINUX_CONFIG_FIXUPS
> + $(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211)
Symbol: CFG80211 [=m]
Type : tristate
Defined at net/wireless/Kconfig:20
Prompt: cfg80211 - wireless configuration API
Depends on: NET [=y] && WIRELESS [=y] && (RFKILL [=y] || !RFKILL [=y])
So we need NET and WIRELESS (RFKILL is just to avoid it as a module).
WIRELESS depends on !s390, so rtl8189es should also not be available for
BR2_s390x, but that's rthogonal to this change.
> + $(call KCONFIG_ENABLE_OPT,CONFIG_MMC)
MMC, for a wireless driver? I've loked at the code, and MMC is not
required. It can be used, yes, but it is not required, i.e. the code is
springled with "#ifdef CONFIG_MMC", so it does not look like mandatory
at all.
Regards,
Yann E. MORIN.
> +endef
> +
> $(eval $(kernel-module))
> $(eval $(generic-package))
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-09-11 20:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 19:57 [Buildroot] [PATCH] package/rtl8189es: fix build failure due to missing Linux options Giulio Benetti
2022-09-11 20:18 ` Yann E. MORIN [this message]
2022-09-11 20:36 ` Giulio Benetti
2022-09-11 21:42 ` [Buildroot] [PATCH v2] " Giulio Benetti
2022-09-17 15:27 ` Thomas Petazzoni
2022-09-25 20:46 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220911201856.GK898622@scaer \
--to=yann.morin.1998@free.fr \
--cc=aussedat.louis@gmail.com \
--cc=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.