From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB3A6C6FA89 for ; Mon, 12 Sep 2022 03:34:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229787AbiILDez (ORCPT ); Sun, 11 Sep 2022 23:34:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229815AbiILDdX (ORCPT ); Sun, 11 Sep 2022 23:33:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A06B729821 for ; Sun, 11 Sep 2022 20:30:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 353126116F for ; Mon, 12 Sep 2022 03:30:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C736C433C1; Mon, 12 Sep 2022 03:30:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1662953431; bh=+hsKsBn1Oz4ONOBVTJGLERKLUb2hOuepjPLqUIzCayU=; h=Date:To:From:Subject:From; b=XCgYrP7piRYxmBJ9egS0L60pDQAtslVMALGJCZSaNOUF8P04vRaRdfGRNp0RZlTOy bkzbbSMUuSx+uczR2k6zBAI2mPEDxe/6VhUZpKydu0vMmqsFHVVcPZ+c/rYatMEruy 98Q5Jhqo+LSvRspCD5j4yuvqtRGbIsCBrcVxqANU= Date: Sun, 11 Sep 2022 20:30:30 -0700 To: mm-commits@vger.kernel.org, jack@suse.cz, hch@lst.de, yi.zhang@huawei.com, akpm@linux-foundation.org From: Andrew Morton Subject: [merged mm-stable] ntfs3-replace-ll_rw_block.patch removed from -mm tree Message-Id: <20220912033031.8C736C433C1@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The quilt patch titled Subject: ntfs3: replace ll_rw_block() has been removed from the -mm tree. Its filename was ntfs3-replace-ll_rw_block.patch This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm ------------------------------------------------------ From: Zhang Yi Subject: ntfs3: replace ll_rw_block() Date: Thu, 1 Sep 2022 21:34:58 +0800 ll_rw_block() is not safe for the sync read path because it cannot guarantee that submitting read IO if the buffer has been locked. We could get false positive EIO after wait_on_buffer() if the buffer has been locked by others. So stop using ll_rw_block() in ntfs_get_block_vbo(). Link: https://lkml.kernel.org/r/20220901133505.2510834-8-yi.zhang@huawei.com Signed-off-by: Zhang Yi Reviewed-by: Jan Kara Reviewed-by: Christoph Hellwig Signed-off-by: Andrew Morton --- fs/ntfs3/inode.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) --- a/fs/ntfs3/inode.c~ntfs3-replace-ll_rw_block +++ a/fs/ntfs3/inode.c @@ -630,12 +630,9 @@ static noinline int ntfs_get_block_vbo(s bh->b_size = block_size; off = vbo & (PAGE_SIZE - 1); set_bh_page(bh, page, off); - ll_rw_block(REQ_OP_READ, 1, &bh); - wait_on_buffer(bh); - if (!buffer_uptodate(bh)) { - err = -EIO; + err = bh_read(bh, 0); + if (err < 0) goto out; - } zero_user_segment(page, off + voff, off + block_size); } } _ Patches currently in -mm which might be from yi.zhang@huawei.com are