From: Adrian Perez de Castro <aperez@igalia.com>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: James Hilliard <james.hilliard1@gmail.com>,
"Yann E . MORIN" <yann.morin.1998@free.fr>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/cog: add weston direct display support
Date: Tue, 13 Sep 2022 21:03:39 +0300 [thread overview]
Message-ID: <20220913210339.GD297238@igalia.com> (raw)
In-Reply-To: <20220909050800.3520691-2-james.hilliard1@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1371 bytes --]
Hi,
Patch set LGTM.
On Thu, 08 Sep 2022 23:08:00 -0600 James Hilliard <james.hilliard1@gmail.com> wrote:
> Enable optional weston direct display support when weston is
> available.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>
> ---
> package/cog/cog.mk | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/package/cog/cog.mk b/package/cog/cog.mk
> index 5f7abcab1f..1f24bebee4 100644
> --- a/package/cog/cog.mk
> +++ b/package/cog/cog.mk
> @@ -14,11 +14,17 @@ COG_LICENSE_FILES = COPYING
> COG_CONF_OPTS = \
> -DCOG_BUILD_PROGRAMS=ON \
> -DCOG_PLATFORM_HEADLESS=ON \
> - -DCOG_WESTON_DIRECT_DISPLAY=OFF \
> -DINSTALL_MAN_PAGES=OFF \
> -DCOG_HOME_URI='$(call qstrip,$(BR2_PACKAGE_COG_PROGRAMS_HOME_URI))' \
> -DUSE_SOUP2=ON
>
> +ifeq ($(BR2_PACKAGE_WESTON),y)
> +COG_CONF_OPTS += -DCOG_WESTON_DIRECT_DISPLAY=ON
> +COG_DEPENDENCIES += weston
> +else
> +COG_CONF_OPTS += -DCOG_WESTON_DIRECT_DISPLAY=OFF
> +endif
> +
> ifeq ($(BR2_PACKAGE_COG_PLATFORM_FDO),y)
> COG_CONF_OPTS += -DCOG_PLATFORM_WL=ON
> COG_DEPENDENCIES += libxkbcommon wayland-protocols
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
>
Cheers,
—Adrián
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-09-13 18:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 5:07 [Buildroot] [PATCH 1/2] package/weston: install to staging James Hilliard
2022-09-09 5:08 ` [Buildroot] [PATCH 2/2] package/cog: add weston direct display support James Hilliard
2022-09-13 18:03 ` Adrian Perez de Castro [this message]
2022-09-13 18:03 ` [Buildroot] [PATCH 1/2] package/weston: install to staging Adrian Perez de Castro
2022-09-17 15:45 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220913210339.GD297238@igalia.com \
--to=aperez@igalia.com \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.