From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2387AC6FA8B for ; Wed, 14 Sep 2022 09:04:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230309AbiINJEH (ORCPT ); Wed, 14 Sep 2022 05:04:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230409AbiINJDO (ORCPT ); Wed, 14 Sep 2022 05:03:14 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 024B977E80; Wed, 14 Sep 2022 02:02:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EFDECB81629; Wed, 14 Sep 2022 09:02:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 885BEC433C1; Wed, 14 Sep 2022 09:02:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663146125; bh=p8Kx8vWWUcrK4uYDU3FPDkTUOC1BDxN54yFm/hp2/Tg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CBbqQCXx56++iunT2RWrcfOhHvjFeLgZdjw8EIhNi8E+fGjtMDY16XDoOZqyP0lUe hxeJ6/yF5nfLGByKAl9UfU7wl46Izy5NTpE6/EgbJsCkg1EkR7alPgIK7SmaoEHxNv 61o9tNP5FV8yyWXyH/w6sRe6gapGovmr3UTLtMXyYhg5MKRQ/DJ63yhlOPo9ux5RbP iwVl4WkweHESapjZLvSjtSZrl0KQ6QhpERSyyijRVNNtW7yTus5PDJ4K2AzmVI1/i7 z9fCFqLE9yy10Y7ch68o7erZX0DeOk48oPR+ZUenjbhOqQCo8cqMjYu4xaTbZGSyLi zOhGK3ZjM9Gvg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sreekanth Reddy , "Martin K . Petersen" , Sasha Levin , sathya.prakash@broadcom.com, suganath-prabu.subramani@broadcom.com, jejb@linux.ibm.com, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 5.19 18/22] scsi: mpt3sas: Fix use-after-free warning Date: Wed, 14 Sep 2022 05:00:59 -0400 Message-Id: <20220914090103.470630-18-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220914090103.470630-1-sashal@kernel.org> References: <20220914090103.470630-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org From: Sreekanth Reddy [ Upstream commit 991df3dd5144f2e6b1c38b8d20ed3d4d21e20b34 ] Fix the following use-after-free warning which is observed during controller reset: refcount_t: underflow; use-after-free. WARNING: CPU: 23 PID: 5399 at lib/refcount.c:28 refcount_warn_saturate+0xa6/0xf0 Link: https://lore.kernel.org/r/20220906134908.1039-2-sreekanth.reddy@broadcom.com Signed-off-by: Sreekanth Reddy Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index 5e8887fa02c8a..e3b7ebf464244 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -3670,6 +3670,7 @@ static struct fw_event_work *dequeue_next_fw_event(struct MPT3SAS_ADAPTER *ioc) fw_event = list_first_entry(&ioc->fw_event_list, struct fw_event_work, list); list_del_init(&fw_event->list); + fw_event_work_put(fw_event); } spin_unlock_irqrestore(&ioc->fw_event_lock, flags); @@ -3751,7 +3752,6 @@ _scsih_fw_event_cleanup_queue(struct MPT3SAS_ADAPTER *ioc) if (cancel_work_sync(&fw_event->work)) fw_event_work_put(fw_event); - fw_event_work_put(fw_event); } ioc->fw_events_cleanup = 0; } -- 2.35.1