From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Teigland Date: Wed, 14 Sep 2022 14:27:54 -0500 Subject: [PATCH] vgremove: PVID file leakage in /run/lvm/pvs_online In-Reply-To: <49411.122090922135500503@us-mta-519.us.mimecast.lan> References: <2cbbffed-1d4c-b351-d9e3-8218d8964a7b@huawei.com> <20220909142734.GA23063@redhat.com> <49411.122090922135500503@us-mta-519.us.mimecast.lan> Message-ID: <20220914192754.GA14873@redhat.com> List-Id: To: lvm-devel@redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, a patch for this is here: https://sourceware.org/git/?p=lvm2.git;a=commit;h=0887896847807e159a70edc5ac92a4030c13923a Dave On Sat, Sep 10, 2022 at 01:56:59AM +0000, liuzhiqiang (I) wrote: > Thanks for your reply. > /run dir is mounted as tmpfs type, which has a setting inode number by systemd service. If the number of leakage pvid files increases with time, it may cause Deny of Service for other apps because cannot create files in /run. > > ????David Teigland > ????LVM2 development > ????zkabelac ;linfeilong ;wuguanghao ;liuzhiqiang (I) > ????2022-09-09 22:27:45 > ????Re: [lvm-devel] [PATCH] vgremove: PVID file leakage in /run/lvm/pvs_online > > On Thu, Sep 08, 2022 at 10:03:40PM +0800, miaoguanqin wrote: > > We found PVID file leakage problem when exec the following test; > > pvcreate /dev/sdb > > vgcreate -s 1M docker /dev/sdb > > lvcreate -L 10M docker > > pvscan --cache --listvg --checkcomplete --vgonline --udevoutput > > --journal=output /dev/sdb > > vgremove -ff docker > > > > pvcreate operation generates a new PVID, which is used to create PVID pvid > > file > > when exec pvcan. However vgremove does not delete the old PVID file. > > > > Here, we will delete all PVID files of each pv in current vg, when exec > > vgremove. > > Hi, these files are located in tmpfs, so they will disappear automatically > when the system reboots. Is there a reason that you want remove them in > vgremove instead of waiting for reboot to remove them?