From: Arshdeep Kaur <arshdeep.kaur@intel.com>
To: dev@dpdk.org
Subject: [PATCH v3] dumpcap: fix interface parameter check.
Date: Thu, 15 Sep 2022 01:16:09 -0700 [thread overview]
Message-ID: <20220915081609.77312-1-arshdeep.kaur@intel.com> (raw)
In-Reply-To: <20220912125328.236907-1-arshdeep.kaur@intel.com>
Correction in handling 'IF' condition for -i parameter.
Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
Signed-off-by: Arshdeep Kaur <arshdeep.kaur@intel.com>
---
app/dumpcap/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
index a6041d4ff4..8972c45a71 100644
--- a/app/dumpcap/main.c
+++ b/app/dumpcap/main.c
@@ -240,7 +240,7 @@ static void select_interface(const char *arg)
{
uint16_t port;
- if (strcmp(arg, "*"))
+ if (!strcmp(arg, "*"))
select_all_interfaces();
else if (rte_eth_dev_get_port_by_name(arg, &port) == 0)
add_interface(port, arg);
--
2.37.1
next prev parent reply other threads:[~2022-09-15 8:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220829084956.288858-1-arshdeep.kaur@intel.com>
2022-09-06 16:17 ` [PATCH] SCSY-192443 Bug fix DPDK-dumpcap for interface parameter Pattan, Reshma
2022-09-12 12:53 ` [PATCH v2] dumpcap: fix interface parameter check Arshdeep Kaur
2022-09-12 13:06 ` Pattan, Reshma
2022-09-15 8:16 ` Arshdeep Kaur [this message]
2022-09-15 8:44 ` [PATCH v3] " Pattan, Reshma
2022-10-31 13:45 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220915081609.77312-1-arshdeep.kaur@intel.com \
--to=arshdeep.kaur@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.