From: SeongJae Park <sj@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-mm@kvack.org, damon@lists.linux.dev, sj@kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH -next 1/2] mm/damon/reclaim: change damon_reclaim_wmarks to static
Date: Thu, 15 Sep 2022 12:56:55 +0000 [thread overview]
Message-ID: <20220915125655.53157-1-sj@kernel.org> (raw)
In-Reply-To: <20220915021024.4177940-1-yangyingliang@huawei.com>
Hi Yang,
On Thu, 15 Sep 2022 10:10:23 +0800 Yang Yingliang <yangyingliang@huawei.com> wrote:
> damon_reclaim_wmarks is only used in reclaim.c now, change it to static.
>
> Fixes: 89dd02d8abd1 ("mm/damon/reclaim: use watermarks parameters generator macro")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
> ---
> mm/damon/reclaim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c
> index 1acf808e1624..039fa55e0ae9 100644
> --- a/mm/damon/reclaim.c
> +++ b/mm/damon/reclaim.c
> @@ -64,7 +64,7 @@ static struct damos_quota damon_reclaim_quota = {
> };
> DEFINE_DAMON_MODULES_DAMOS_QUOTAS(damon_reclaim_quota);
>
> -struct damos_watermarks damon_reclaim_wmarks = {
> +static struct damos_watermarks damon_reclaim_wmarks = {
> .metric = DAMOS_WMARK_FREE_MEM_RATE,
> .interval = 5000000, /* 5 seconds */
> .high = 500, /* 50 percent */
> --
> 2.25.1
>
>
prev parent reply other threads:[~2022-09-15 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 2:10 [PATCH -next 1/2] mm/damon/reclaim: change damon_reclaim_wmarks to static Yang Yingliang
2022-09-15 2:10 ` [PATCH -next 2/2] mm/damon/lru_sort: change damon_lru_sort_wmarks " Yang Yingliang
2022-09-15 12:57 ` SeongJae Park
2022-09-15 12:56 ` SeongJae Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220915125655.53157-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-mm@kvack.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.