From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ACE7ECAAA1 for ; Thu, 15 Sep 2022 18:56:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229567AbiIOS4Q (ORCPT ); Thu, 15 Sep 2022 14:56:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229581AbiIOS4O (ORCPT ); Thu, 15 Sep 2022 14:56:14 -0400 Received: from mx4.wp.pl (mx4.wp.pl [212.77.101.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4620A3CBE4 for ; Thu, 15 Sep 2022 11:56:12 -0700 (PDT) Received: (wp-smtpd smtp.wp.pl 30133 invoked from network); 15 Sep 2022 20:56:09 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1663268169; bh=/kZNb5DNcT8xTO7N7vLzj5Lbw+oKmWuyq0FnzqOHWCo=; h=From:To:Cc:Subject; b=nw+9uXWfEXk1XFlGurG8fvqbjyLbTOPX5S7RDZZpQqyjdq4Fhw4zpDGvIG6V7j38v ZwQBmksWDjV246ZCBCa4wCDNa2se7DimHnq1RgyurGa3Her+YkPMGTSBySamAhA4kO 3PHn2/FlCdX7q3l0TgArzcrdPK5bsKSeJZ9V9Ia8= Received: from 89-64-7-128.dynamic.chello.pl (HELO localhost) (stf_xl@wp.pl@[89.64.7.128]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 15 Sep 2022 20:56:09 +0200 Date: Thu, 15 Sep 2022 20:56:08 +0200 From: Stanislaw Gruszka To: Hans de Goede Cc: Helmut Schaa , Kalle Valo , linux-wireless@vger.kernel.org Subject: Re: [PATCH 1/1] wifi: rt2x00: Fix "Error - Attempt to send packet over invalid queue 2" Message-ID: <20220915185608.GA10590@wp.pl> References: <20220908173618.155291-1-hdegoede@redhat.com> <20220908173618.155291-2-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220908173618.155291-2-hdegoede@redhat.com> X-WP-MailID: 0cf9e79b1ff8969f4ecab3c8f3fb0e5f X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000000 [AfMx] Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, Sep 08, 2022 at 07:36:18PM +0200, Hans de Goede wrote: > Even though ieee80211_hw.queues is set to 2, the ralink rt2x00 driver > is seeing tx skbs submitted to it with the queue-id set to 2 / set to > IEEE80211_AC_BE on a rt2500 card when associating with an access-point. I'm impressed you have still working rt2500 card :-) > This causes rt2x00queue_get_tx_queue() to return NULL and the following > error to be logged: "ieee80211 phy0: rt2x00mac_tx: Error - Attempt to > send packet over invalid queue 2", after which association with the AP > fails. > > This patch works around this by mapping QID_AC_BE and QID_AC_BK > to QID_AC_VI when there are only 2 tx_queues. > > Signed-off-by: Hans de Goede Acked-by: Stanislaw Gruszka