From: Florian Westphal <fw@strlen.de>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
syzbot <syzbot+b5d82a651b71cd8a75ab@syzkaller.appspotmail.com>,
syzkaller-bugs@googlegroups.com, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org,
Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH] netfilter: nf_tables: fix nft_counters_enabled underflow at nf_tables_addchain()
Date: Thu, 15 Sep 2022 22:19:48 +0200 [thread overview]
Message-ID: <20220915201948.GA4385@breakpoint.cc> (raw)
In-Reply-To: <8c86a1bb-9c43-b02e-cf93-e098b158ee8c@I-love.SAKURA.ne.jp>
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:
> syzbot is reporting underflow of nft_counters_enabled counter at
> nf_tables_addchain() [1], for commit 43eb8949cfdffa76 ("netfilter:
> nf_tables: do not leave chain stats enabled on error") missed that
> nf_tables_chain_destroy() after nft_basechain_init() in the error path of
> nf_tables_addchain() decrements the counter because nft_basechain_init()
> makes nft_is_base_chain() return true by setting NFT_CHAIN_BASE flag.
>
> Increment the counter immediately after returning from
> nft_basechain_init().
Applied, thanks.
prev parent reply other threads:[~2022-09-15 20:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 10:48 [syzbot] WARNING in static_key_slow_try_dec (3) syzbot
2022-09-12 12:41 ` [PATCH] netfilter: nf_tables: fix nft_counters_enabled underflow at nf_tables_addchain() Tetsuo Handa
2022-09-12 12:44 ` Pablo Neira Ayuso
2022-09-15 20:19 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220915201948.GA4385@breakpoint.cc \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=kadlec@netfilter.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=syzbot+b5d82a651b71cd8a75ab@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.