All of lore.kernel.org
 help / color / mirror / Atom feed
From: "jay.xu@rock-chips.com" <jay.xu@rock-chips.com>
To: linus.walleij <linus.walleij@linaro.org>
Cc: "Johan Jonker" <jbx6244@gmail.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	linux-gpio <linux-gpio@vger.kernel.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>
Subject: Re: Re: [PATCH 2/3] pinctrl: export function get_pinctrl_dev_from_devname()
Date: Fri, 16 Sep 2022 16:46:07 +0800	[thread overview]
Message-ID: <202209161646069403891@rock-chips.com> (raw)
In-Reply-To: CACRpkdZa7YNpO95=D0wyMWPXe6f8HYDwUhOfXdH15kjZYMGMeg@mail.gmail.com

Hi walleij

--------------
jay.xu@rock-chips.com
>On Thu, Sep 15, 2022 at 4:13 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:
>
>> Export get_pinctrl_dev_from_devname() as GPL and add to pinctrl head file.
>>
>> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
>> ---
>>  drivers/pinctrl/core.c          | 1 +
>>  include/linux/pinctrl/pinctrl.h | 1 +
>
>If you add it to <linux/pinctrl/pinctrl.h> you need to remove it from
>drivers/pinctrl/core.h.
>
>I suggest you just include the local header instead.
>
>#include "../pinctrl/pinctrl.h"
>
>Maybe not the most elegant but it keeps the interface private to
>pinctrl and GPIO and not broadcast to the entire kernel.
>
>If it looks very ugly, well then it is probably because this driver
>should move into drivers/pinctrl.
> 
I pushed a new patchset, drop pinctrl from gpio driver, then this patch is not need again.
please help to give a review to that.

Thanks.

>Yours,
>Linus Walleij
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2022-09-16  8:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15  2:13 [PATCH v6 0/3] gpio: rockchip: support acpi Jianqun Xu
2022-09-15  2:13 ` Jianqun Xu
2022-09-15  2:13 ` [PATCH 1/3] ACPI: utils: Add acpi_dev_uid_to_integer() helper to get _UID as integer Jianqun Xu
2022-09-15  2:13   ` Jianqun Xu
2022-09-15  2:13 ` [PATCH 2/3] pinctrl: export function get_pinctrl_dev_from_devname() Jianqun Xu
2022-09-15  2:13   ` Jianqun Xu
2022-09-15  8:43   ` Linus Walleij
2022-09-15  8:43     ` Linus Walleij
2022-09-16  8:46     ` jay.xu [this message]
2022-09-15  2:13 ` [PATCH 3/3] gpio: rockchip: support acpi Jianqun Xu
2022-09-15  2:13   ` Jianqun Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202209161646069403891@rock-chips.com \
    --to=jay.xu@rock-chips.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=brgl@bgdev.pl \
    --cc=heiko@sntech.de \
    --cc=jbx6244@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.