From: Miklos Szeredi <mszeredi@redhat.com>
To: linux-fsdevel@vger.kernel.org
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
Amir Goldstein <amir73il@gmail.com>,
David Howells <dhowells@redhat.com>,
Yu-li Lin <yulilin@google.com>,
Chirantan Ekbote <chirantan@chromium.org>
Subject: [PATCH 5/8] vfs: make vfs_tmpfile() static
Date: Fri, 16 Sep 2022 21:44:13 +0200 [thread overview]
Message-ID: <20220916194416.1657716-5-mszeredi@redhat.com> (raw)
In-Reply-To: <20220916194416.1657716-1-mszeredi@redhat.com>
No callers outside of fs/namei.c anymore.
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
---
fs/namei.c | 3 +--
include/linux/fs.h | 3 ---
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/fs/namei.c b/fs/namei.c
index 078ecd88f016..eacaf9ccbaa6 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -3583,7 +3583,7 @@ static int do_open(struct nameidata *nd,
* On non-idmapped mounts or if permission checking is to be performed on the
* raw inode simply passs init_user_ns.
*/
-struct dentry *vfs_tmpfile(struct user_namespace *mnt_userns,
+static struct dentry *vfs_tmpfile(struct user_namespace *mnt_userns,
struct dentry *dentry, umode_t mode, int open_flag)
{
struct dentry *child = NULL;
@@ -3622,7 +3622,6 @@ struct dentry *vfs_tmpfile(struct user_namespace *mnt_userns,
dput(child);
return ERR_PTR(error);
}
-EXPORT_SYMBOL(vfs_tmpfile);
/**
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 34e7a189565b..a445da4842e0 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2004,9 +2004,6 @@ static inline int vfs_whiteout(struct user_namespace *mnt_userns,
WHITEOUT_DEV);
}
-struct dentry *vfs_tmpfile(struct user_namespace *mnt_userns,
- struct dentry *dentry, umode_t mode, int open_flag);
-
struct file *tmpfile_open(struct user_namespace *mnt_userns,
const struct path *parentpath,
umode_t mode, int open_flag, const struct cred *cred);
--
2.37.3
next prev parent reply other threads:[~2022-09-16 19:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 19:44 [PATCH 1/8] cachefiles: tmpfile error handling cleanup Miklos Szeredi
2022-09-16 19:44 ` [PATCH 2/8] vfs: add tmpfile_open() helper Miklos Szeredi
2022-09-16 19:44 ` [PATCH 3/8] cachefiles: use " Miklos Szeredi
2022-09-16 19:44 ` [PATCH 4/8] ovl: " Miklos Szeredi
2022-09-16 19:44 ` Miklos Szeredi [this message]
2022-09-16 19:44 ` [PATCH 6/8] vfs: move open right after ->tmpfile() Miklos Szeredi
2022-09-16 19:44 ` [PATCH 7/8] vfs: open inside ->tmpfile() Miklos Szeredi
2022-09-16 22:04 ` kernel test robot
2022-09-17 1:28 ` kernel test robot
2022-09-17 1:49 ` kernel test robot
2022-09-16 19:44 ` [PATCH 8/8] fuse: implement ->tmpfile() Miklos Szeredi
2022-09-16 21:52 ` Bernd Schubert
2022-09-19 6:30 ` Miklos Szeredi
2022-09-19 7:16 ` Bernd Schubert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220916194416.1657716-5-mszeredi@redhat.com \
--to=mszeredi@redhat.com \
--cc=amir73il@gmail.com \
--cc=chirantan@chromium.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=yulilin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.