From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Daniel Golle <daniel@makrotopia.org>
Cc: linux-wireless@vger.kernel.org,
Helmut Schaa <helmut.schaa@googlemail.com>,
Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH 09/15] rt2x00: add TX LOFT calibration for MT7620
Date: Sat, 17 Sep 2022 15:04:01 +0200 [thread overview]
Message-ID: <20220917130401.GK17901@wp.pl> (raw)
In-Reply-To: <YyUBkIKr/KrBsOcD@makrotopia.org>
On Sat, Sep 17, 2022 at 12:06:56AM +0100, Daniel Golle wrote:
> +static void rt2800_loft_search(struct rt2x00_dev *rt2x00dev, u8 ch_idx,
> + u8 alc_idx, u8 dc_result[][RF_ALC_NUM][2])
> +{
> + u32 p0 = 0, p1 = 0, pf = 0;
> + char idx0 = 0, idx1 = 0;
> + u8 idxf[] = {0x00, 0x00};
> + u8 ibit = 0x20;
> + u8 iorq;
> + char bidx;
> +
> + rt2800_bbp_write(rt2x00dev, 158, 0xb0);
> + rt2800_bbp_write(rt2x00dev, 159, 0x80);
> +
> + for (bidx = 5; bidx >= 0; bidx--) {
> + for (iorq = 0; iorq <= 1; iorq++) {
> + rt2x00_dbg(rt2x00dev, "\n========================================================\n");
Is this useful for debugging ?
> +void rt2800_loft_iq_calibration(struct rt2x00_dev *rt2x00dev)
> +{
> + struct rf_reg_pair rf_store[CHAIN_NUM][13];
> + u32 macorg1 = 0;
> + u32 macorg2 = 0;
> + u32 macorg3 = 0;
> + u32 macorg4 = 0;
> + u32 macorg5 = 0;
> + u32 orig528 = 0;
> + u32 orig52c = 0;
> +
> + u32 savemacsysctrl = 0, mtxcycle = 0;
> + u32 macvalue = 0;
> + u32 mac13b8 = 0;
> + u32 p0 = 0, p1 = 0;
> + u32 p0_idx10 = 0, p1_idx10 = 0;
> +
> + u8 rfvalue;
> + u8 loft_dc_search_result[CHAIN_NUM][RF_ALC_NUM][2];
> + u8 ger[CHAIN_NUM], per[CHAIN_NUM];
> + u8 rf_gain[] = {0x00, 0x01, 0x02, 0x04, 0x08, 0x0c};
> + u8 rfvga_gain_table[] = {0x24, 0x25, 0x26, 0x27, 0x28, 0x2c, 0x2d, 0x2e, 0x2f, 0x30,
> + 0x31, 0x38, 0x39, 0x3a, 0x3b, 0x3c, 0x3d, 0x3e, 0x3F};
> + u8 vga_gain[] = {14, 14};
> + u8 bbp_2324gain[] = {0x16, 0x14, 0x12, 0x10, 0x0c, 0x08};
We should use static const for those.
> + u8 bbp = 0, ch_idx = 0, rf_alc_idx = 0, idx = 0;
> + u8 bbpr30, rfb0r39, rfb0r42;
> + u8 bbpr1;
> + u8 bbpr4;
> + u8 bbpr241, bbpr242;
> + u8 count_step;
This function one is also huge too and I think require a bit refacing
int smaller sub functions. Also utilize lot of stack, there are no
warnings about too much stack consuming ?
prev parent reply other threads:[~2022-09-17 13:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 23:06 [PATCH 09/15] rt2x00: add TX LOFT calibration for MT7620 Daniel Golle
2022-09-17 13:04 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220917130401.GK17901@wp.pl \
--to=stf_xl@wp.pl \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=helmut.schaa@googlemail.com \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.