All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Chris Dimich <chris.dimich@boundarydevices.com>
Cc: Gary Bisson <bisson.gary@gmail.com>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>,
	Refik Tuzakli <tuzakli.refik@gmail.com>,
	buildroot@buildroot.org,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Romain Naour <romain.naour@gmail.com>,
	Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Subject: Re: [Buildroot] [PATCH 6/7] package/freescale-imx/imx-vpu-hantro-vc: bump version to 1.7.0
Date: Sat, 17 Sep 2022 22:21:04 +0200	[thread overview]
Message-ID: <20220917222104.4a615677@windsurf> (raw)
In-Reply-To: <20220824192604.2549356-13-chris.dimich@boundarydevices.com>

Hello Chris,

On Wed, 24 Aug 2022 12:26:03 -0700
Chris Dimich <chris.dimich@boundarydevices.com> wrote:

> -To match NXP 5.15.32-2.0.0 release.
> -EULA/COPYING: update to LA_OPT_NXP_Software_License v35.
> -Add an INSTALL_STAGING_CMDS define as libraries needed by imx-vpu-hantro-daemon.

Please split the version bump from the installation to staging into
separate patches. These are unrelated things, so they belong into
separate commits.

> -sha256  d5efae484c4271c098286d007590d6bf40c272d4f35702ff65625f2362715ab3  imx-vpu-hantro-vc-1.4.0.bin
> -sha256  ea58636bf34f589048fcd46e38497c47229fde8498df086ff5fb52f9ef8e15ee  COPYING
> -sha256  50099e283cfd307f84f159aeb1a6f462351320273dbcdb80d7f2c9db0494b71c  EULA
> +sha256  8af665f8e06e0e467f563e372f43583d94128f0d37f75321965bc26bd4404b2b  imx-vpu-hantro-vc-1.7.0.bin
> +sha256  35188e65dbb9c7da4bbcb77c7726e835607f9f41b8b44149806ea51429ca9a31  COPYING
> +sha256  35188e65dbb9c7da4bbcb77c7726e835607f9f41b8b44149806ea51429ca9a31  EULA

Here as well, the EULA hash is wrong:

>>> imx-vpu-hantro-vc 1.7.0 Collecting legal info
ERROR: EULA has wrong sha256 hash:
ERROR: expected: 35188e65dbb9c7da4bbcb77c7726e835607f9f41b8b44149806ea51429ca9a31
ERROR: got     : 30f61825583b4c26d29a798ad7e4c8ef2f2f390b1e964af302d2dc40e93cb0a4
ERROR: Incomplete download, or man-in-the-middle (MITM) attack

Please make sure that "make legal-info" works in a configuration where
you have this package enabled.

> +define IMX_VPU_HANTRO_VC_INSTALL_STAGING_CMDS
> +	cp -r $(@D)/usr/include/hantro_VC8000E_enc $(STAGING_DIR)/usr/include/
> +	cp $(@D)/usr/lib/libhantro_vc8000e.so $(STAGING_DIR)/usr/lib/
> +	cp $(@D)/usr/lib/libhantro_vc8000e.so.1 $(STAGING_DIR)/usr/lib/

Please use the same commands as the target installation. The
INSTALL_TARGET_CMDS are using $(INSTALL) -D -m 0755, so you should do
the same here.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-09-17 20:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-24 19:25 [Buildroot] [PATCH 1/7] toolchain/toolchain-external: update Arm AArch64 toolchain 11.2-2022.02 Chris Dimich
2022-08-24 19:25 ` [Buildroot] [PATCH 2/7] package/weston: add BR2_PACKAGE_WESTON_DEPRECATED_WL_SHELL config Chris Dimich
2022-08-24 19:25 ` [Buildroot] [PATCH 3/7] package/freescale-imx/kernel-module-imx-gpu-viv: bump to version 6.4.3.p4.2 Chris Dimich
2022-08-24 19:25 ` [Buildroot] [PATCH 4/7] package/freescale-imx/imx-gpu-viv: " Chris Dimich
2022-08-24 19:25 ` [Buildroot] [PATCH 5/7] package/freescale-imx/imx-gpu-g2d: bump version to 6.4.3.p4.2 Chris Dimich
2022-08-24 19:25 ` [Buildroot] [PATCH 6/7] package/freescale-imx/imx-vpu-hantro-vc: bump version to 1.7.0 Chris Dimich
2022-08-24 19:25 ` [Buildroot] [PATCH 7/7] package/freescale-imx/imx-vpu-hantro-daemon: add package Chris Dimich
2022-08-24 19:25 ` [Buildroot] [PATCH 1/7] toolchain/toolchain-external: update Arm AArch64 toolchain 11.2-2022.02 Chris Dimich
2022-08-28 15:29   ` Yann E. MORIN
2022-08-24 19:25 ` [Buildroot] [PATCH 2/7] package/weston: add BR2_PACKAGE_WESTON_DEPRECATED_WL_SHELL config Chris Dimich
2022-08-28 15:15   ` Yann E. MORIN
2022-09-02 18:22     ` Chris Dimich
2022-08-24 19:26 ` [Buildroot] [PATCH 3/7] package/freescale-imx/kernel-module-imx-gpu-viv: bump to version 6.4.3.p4.2 Chris Dimich
2022-08-28 15:44   ` Yann E. MORIN
2022-08-29 12:51     ` Gary Bisson
2022-09-02 18:43       ` Yann E. MORIN
2022-08-24 19:26 ` [Buildroot] [PATCH 4/7] package/freescale-imx/imx-gpu-viv: " Chris Dimich
2022-08-24 19:26 ` [Buildroot] [PATCH 5/7] package/freescale-imx/imx-gpu-g2d: bump version to 6.4.3.p4.2 Chris Dimich
2022-09-17 20:15   ` Thomas Petazzoni
2022-08-24 19:26 ` [Buildroot] [PATCH 6/7] package/freescale-imx/imx-vpu-hantro-vc: bump version to 1.7.0 Chris Dimich
2022-09-17 20:21   ` Thomas Petazzoni [this message]
2022-08-24 19:26 ` [Buildroot] [PATCH 7/7] package/freescale-imx/imx-vpu-hantro-daemon: add package Chris Dimich
2022-09-17 20:26   ` Thomas Petazzoni
  -- strict thread matches above, loose matches on Subject: below --
2022-08-24  2:48 [Buildroot] [PATCH 1/7] toolchain/toolchain-external: update Arm AArch64 toolchain 11.2-2022.02 Chris Dimich
2022-08-24  2:48 ` [Buildroot] [PATCH 6/7] package/freescale-imx/imx-vpu-hantro-vc: bump version to 1.7.0 Chris Dimich
2022-08-24  2:49 ` Chris Dimich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220917222104.4a615677@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=bisson.gary@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=chris.dimich@boundarydevices.com \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=romain.naour@gmail.com \
    --cc=thomas.de_schampheleire@nokia.com \
    --cc=tuzakli.refik@gmail.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.