From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/mbedtls: use pre-configure, not post-patch, hooks to configure
Date: Sun, 18 Sep 2022 12:20:45 +0200 [thread overview]
Message-ID: <20220918122045.2a7710f6@windsurf> (raw)
In-Reply-To: <20220828195445.3354590-1-yann.morin.1998@free.fr>
On Sun, 28 Aug 2022 21:54:45 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> Currently, we use post-patch hooks to apply our configuration settings.
> This works, but this is semantically wrong; post-patch hooks are there
> to amend the source code to actually fix it (i.e. because it can't be
> done with a patch for example).
>
> Configuring the package, on the other hand, belong to the configure
> step, and if we need to tweak the source code for configuration
> purposes, this should be done in pre-configure hooks.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/mbedtls/mbedtls.mk | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-09-18 10:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-28 19:54 [Buildroot] [PATCH] package/mbedtls: use pre-configure, not post-patch, hooks to configure Yann E. MORIN
2022-09-18 10:20 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220918122045.2a7710f6@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.