From: Tony Asleson <tasleson@sourceware.org>
To: lvm-devel@redhat.com
Subject: main - lvmdbusd: Raise IOError instead of ignoring
Date: Mon, 19 Sep 2022 15:58:43 +0000 (GMT) [thread overview]
Message-ID: <20220919155843.588D3385829C@sourceware.org> (raw)
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=8e1e40c499a0e46a0a15b9a6b470adb8fbbbbf4f
Commit: 8e1e40c499a0e46a0a15b9a6b470adb8fbbbbf4f
Parent: 2c5762038a7d2877dca91593ca212e0e36802dc1
Author: Tony Asleson <tasleson@redhat.com>
AuthorDate: Thu Sep 8 15:41:20 2022 -0500
Committer: Tony Asleson <tasleson@redhat.com>
CommitterDate: Fri Sep 16 10:49:37 2022 -0500
lvmdbusd: Raise IOError instead of ignoring
We end up in a bad state if we simply eat IOErrors here. Exit the lvmshell
process and raise the IOError.
---
daemons/lvmdbusd/lvm_shell_proxy.py.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/daemons/lvmdbusd/lvm_shell_proxy.py.in b/daemons/lvmdbusd/lvm_shell_proxy.py.in
index 244fe93f5..ed2c7bc9e 100755
--- a/daemons/lvmdbusd/lvm_shell_proxy.py.in
+++ b/daemons/lvmdbusd/lvm_shell_proxy.py.in
@@ -108,7 +108,8 @@ class LVMShellProxy(object):
except IOError as ioe:
log_debug(str(ioe))
- pass
+ self.exit_shell()
+ raise ioe
if keep_reading and run.value == 0:
# We didn't complete as we are shutting down
reply other threads:[~2022-09-19 15:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220919155843.588D3385829C@sourceware.org \
--to=tasleson@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.