All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
	Saeed Mahameed <saeedm@nvidia.com>,
	Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [PATCH net-next 1/4] net/tls: Describe ciphers sizes by const structs
Date: Mon, 19 Sep 2022 18:47:03 -0700	[thread overview]
Message-ID: <20220919184703.5e0d2d44@kernel.org> (raw)
In-Reply-To: <20220914090520.4170-2-gal@nvidia.com>

On Wed, 14 Sep 2022 12:05:17 +0300 Gal Pressman wrote:
> +#define CIPHER_SIZE_DESC(cipher) [cipher] { \

I'll hopefully get to doing more meaningful reviews tomorrow, 
but in the meantime please send a v2 fixing the compiler issues.

This macro makes gcc unhappy, should likely be [cipher] = { ?

  reply	other threads:[~2022-09-20  1:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-14  9:05 [PATCH net-next 0/4] Support 256 bit TLS keys with device offload Gal Pressman
2022-09-14  9:05 ` [PATCH net-next 1/4] net/tls: Describe ciphers sizes by const structs Gal Pressman
2022-09-20  1:47   ` Jakub Kicinski [this message]
2022-09-20  9:40     ` Gal Pressman
2022-09-14  9:05 ` [PATCH net-next 2/4] net/tls: Use cipher sizes structs Gal Pressman
2022-09-14 10:22   ` Tariq Toukan
2022-09-14  9:05 ` [PATCH net-next 3/4] net/tls: Support 256 bit keys with TX device offload Gal Pressman
2022-09-14 10:22   ` Tariq Toukan
2022-09-14  9:05 ` [PATCH net-next 4/4] net/mlx5e: Support 256 bit keys with kTLS " Gal Pressman
2022-09-14 10:23   ` Tariq Toukan
2022-09-20  1:47   ` Jakub Kicinski
2022-09-20  9:40     ` Gal Pressman
  -- strict thread matches above, loose matches on Subject: below --
2022-09-14 22:03 [PATCH net-next 1/4] net/tls: Describe ciphers sizes by const structs kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220919184703.5e0d2d44@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=gal@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.