From: Jakub Kicinski <kuba@kernel.org>
To: Peilin Ye <yepeilin.cs@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Peilin Ye <peilin.ye@bytedance.com>,
Cong Wang <cong.wang@bytedance.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Alexei Starovoitov <ast@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] udp: Refactor udp_read_skb()
Date: Tue, 20 Sep 2022 17:40:52 -0700 [thread overview]
Message-ID: <20220920174052.47d9858b@kernel.org> (raw)
In-Reply-To: <20220920173859.6137f9e9@kernel.org>
On Tue, 20 Sep 2022 17:38:59 -0700 Jakub Kicinski wrote:
> On Wed, 14 Sep 2022 01:15:30 -0700 Peilin Ye wrote:
> > Delete the unnecessary while loop in udp_read_skb() for readability.
> > Additionally, since recv_actor() cannot return a value greater than
> > skb->len (see sk_psock_verdict_recv()), remove the redundant check.
>
> These don't apply cleanly, please rebase?
Ah, it's the WARN_ON_ONCE() change. In that case please resend after
net is merged into net-next (Thu evening).
next prev parent reply other threads:[~2022-09-21 0:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 8:15 [PATCH net-next 1/2] udp: Refactor udp_read_skb() Peilin Ye
2022-09-14 8:15 ` [PATCH net-next 2/2] af_unix: Refactor unix_read_skb() Peilin Ye
2022-09-21 0:38 ` [PATCH net-next 1/2] udp: Refactor udp_read_skb() Jakub Kicinski
2022-09-21 0:40 ` Jakub Kicinski [this message]
2022-09-21 1:05 ` Peilin Ye
2022-09-23 4:59 ` [PATCH net-next RESEND " Peilin Ye
2022-09-23 4:59 ` [PATCH net-next RESEND 2/2] af_unix: Refactor unix_read_skb() Peilin Ye
2022-09-26 18:20 ` [PATCH net-next RESEND 1/2] udp: Refactor udp_read_skb() patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920174052.47d9858b@kernel.org \
--to=kuba@kernel.org \
--cc=ast@kernel.org \
--cc=cong.wang@bytedance.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peilin.ye@bytedance.com \
--cc=yepeilin.cs@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.