From: Jakub Kicinski <kuba@kernel.org>
To: Liang He <windhl@126.com>
Cc: tchornyi@marvell.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, linux@armlinux.org.uk, netdev@vger.kernel.org
Subject: Re: [PATCH] net: marvell: Fix refcounting bugs in prestera_port_sfp_bind()
Date: Tue, 20 Sep 2022 17:45:29 -0700 [thread overview]
Message-ID: <20220920174529.3e8e106d@kernel.org> (raw)
In-Reply-To: <20220915040655.4007281-1-windhl@126.com>
On Thu, 15 Sep 2022 12:06:55 +0800 Liang He wrote:
> In prestera_port_sfp_bind(), there are two refcounting bugs:
> (1) we should call of_node_get() before of_find_node_by_name() as
> it will automaitcally decrease the refcount of 'from' argument;
> (2) we should call of_node_put() for the break of the iteration
> for_each_child_of_node() as it will automatically increase and
> decrease the 'child'.
>
> Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
> Signed-off-by: Liang He <windhl@126.com>
Please repost and CC all the authors of the patch under Fixes.
next prev parent reply other threads:[~2022-09-21 0:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 4:06 [PATCH] net: marvell: Fix refcounting bugs in prestera_port_sfp_bind() Liang He
2022-09-21 0:45 ` Jakub Kicinski [this message]
2022-09-21 9:02 ` Liang He
2022-09-21 12:36 ` Jakub Kicinski
2022-09-21 13:26 ` Liang He
-- strict thread matches above, loose matches on Subject: below --
2022-09-21 13:32 Liang He
2022-09-21 22:47 ` Yevhen Orlov
2022-09-22 14:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920174529.3e8e106d@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tchornyi@marvell.com \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.