From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D62A8C32771 for ; Wed, 21 Sep 2022 10:40:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229911AbiIUKj7 (ORCPT ); Wed, 21 Sep 2022 06:39:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230038AbiIUKjx (ORCPT ); Wed, 21 Sep 2022 06:39:53 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01D9915A2D for ; Wed, 21 Sep 2022 03:39:48 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oax8d-0003B3-Nx; Wed, 21 Sep 2022 12:39:31 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1oax8c-0007fE-T1; Wed, 21 Sep 2022 12:39:30 +0200 Date: Wed, 21 Sep 2022 12:39:30 +0200 From: Sascha Hauer To: Vinod Koul Cc: Dario Binacchi , linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com, Michael Trimarchi , stable@vger.kernel.org, Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND PATCH v5 1/2] dmaengine: mxs: use platform_driver_register Message-ID: <20220921103930.GM12909@pengutronix.de> References: <20220904141020.2947725-1-dario.binacchi@amarulasolutions.com> <20220913163510.GR6477@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dmaengine@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Wed, Sep 21, 2022 at 08:53:23AM +0530, Vinod Koul wrote: > On 20-09-22, 19:10, Dario Binacchi wrote: > > Hi Vinoud, > > > > On Tue, Sep 13, 2022 at 6:35 PM Sascha Hauer wrote: > > > > > > Hi Dario, > > > > > > On Sun, Sep 04, 2022 at 04:10:19PM +0200, Dario Binacchi wrote: > > > > Driver registration fails on SOC imx8mn as its supplier, the clock > > > > control module, is probed later than subsys initcall level. This driver > > > > uses platform_driver_probe which is not compatible with deferred probing > > > > and won't be probed again later if probe function fails due to clock not > > > > being available at that time. > > > > > > > > This patch replaces the use of platform_driver_probe with > > > > platform_driver_register which will allow probing the driver later again > > > > when the clock control module will be available. > > > > > > > > Fixes: a580b8c5429a ("dmaengine: mxs-dma: add dma support for i.MX23/28") > > > > Co-developed-by: Michael Trimarchi > > > > Signed-off-by: Michael Trimarchi > > > > Signed-off-by: Dario Binacchi > > > > Cc: stable@vger.kernel.org > > > > > > How I see it v3 of this patch is perfectly fine and should be taken > > > instead of this one. I just commented that to v3. > > > > > > Not sure if Vinod would take v3, or if you should resend v3 as v6 > > > instead. If you do, you can add my Acked-by. > > > > > > Vinod, please let us know what you prefer. > > > > Could you please let me know how to proceed? This patch has been pending for > > a while and it's a real shame as the change is minimal and fixes a > > real issue that is > > still present in the mainline and stable kernels. > > Ooops, Somehow this seems to have really slipped. Sorry I owe you an > apology for this > > I am still not sure of this patch yet, lets get it right and merged > quickly. I will send my review later today I just realized that unlike what I said v3 of this patch is still wrong as it leaves the __init annotation on mxs_dma_init() which is called from (non __init) mxs_dma_probe(). v3 probably doesn't give a section mismatch warning because mxs_dma_init() is inlined. Really v2 is the one we should take which is at: https://lore.kernel.org/linux-arm-kernel/20220523132247.1429321-1-dario.binacchi@amarulasolutions.com/T/ Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 366B3C32771 for ; Wed, 21 Sep 2022 10:40:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GNg5hPQA2U70FGIlswD4zPl8UK8ZocCSryOQwGaNGoY=; b=UKUCUPFPfhXAr6 jS9zLHzuL7KxOc+drqGcdxs6yB3sWyGiKa9DWpv9tiFJXpsIPIfmnLcCw51kCY9hJHVRA1Vh+L1YJ Si0tALPlELClSoyej5bhTThsE9mTzFb4yHQPxlTEnb+MYorcDt/dIimQsCQGxZqEzW/mEuVaSxvuR 0lJCmqumCHAvfty411otYqcmAK2ARpt/mUXImLMk8St+VrbHFef0ufj+PHCiJ8IIBXoqYcQUn2VYW i9IWfsC+M6KFsLaxVb011Hxqom7kw4ZZkKmjvRNtXjKGGTrqM3R78TFLXQPdmdKg0crfpFEPTtdqq vlYhEkUJ57fy/IiZfMDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oax92-00AuIi-JM; Wed, 21 Sep 2022 10:39:56 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oax8x-00AuGC-Mc for linux-arm-kernel@lists.infradead.org; Wed, 21 Sep 2022 10:39:53 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oax8d-0003B3-Nx; Wed, 21 Sep 2022 12:39:31 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1oax8c-0007fE-T1; Wed, 21 Sep 2022 12:39:30 +0200 Date: Wed, 21 Sep 2022 12:39:30 +0200 From: Sascha Hauer To: Vinod Koul Cc: Dario Binacchi , linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com, Michael Trimarchi , stable@vger.kernel.org, Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND PATCH v5 1/2] dmaengine: mxs: use platform_driver_register Message-ID: <20220921103930.GM12909@pengutronix.de> References: <20220904141020.2947725-1-dario.binacchi@amarulasolutions.com> <20220913163510.GR6477@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220921_033951_758536_4DC57327 X-CRM114-Status: GOOD ( 39.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 21, 2022 at 08:53:23AM +0530, Vinod Koul wrote: > On 20-09-22, 19:10, Dario Binacchi wrote: > > Hi Vinoud, > > > > On Tue, Sep 13, 2022 at 6:35 PM Sascha Hauer wrote: > > > > > > Hi Dario, > > > > > > On Sun, Sep 04, 2022 at 04:10:19PM +0200, Dario Binacchi wrote: > > > > Driver registration fails on SOC imx8mn as its supplier, the clock > > > > control module, is probed later than subsys initcall level. This driver > > > > uses platform_driver_probe which is not compatible with deferred probing > > > > and won't be probed again later if probe function fails due to clock not > > > > being available at that time. > > > > > > > > This patch replaces the use of platform_driver_probe with > > > > platform_driver_register which will allow probing the driver later again > > > > when the clock control module will be available. > > > > > > > > Fixes: a580b8c5429a ("dmaengine: mxs-dma: add dma support for i.MX23/28") > > > > Co-developed-by: Michael Trimarchi > > > > Signed-off-by: Michael Trimarchi > > > > Signed-off-by: Dario Binacchi > > > > Cc: stable@vger.kernel.org > > > > > > How I see it v3 of this patch is perfectly fine and should be taken > > > instead of this one. I just commented that to v3. > > > > > > Not sure if Vinod would take v3, or if you should resend v3 as v6 > > > instead. If you do, you can add my Acked-by. > > > > > > Vinod, please let us know what you prefer. > > > > Could you please let me know how to proceed? This patch has been pending for > > a while and it's a real shame as the change is minimal and fixes a > > real issue that is > > still present in the mainline and stable kernels. > > Ooops, Somehow this seems to have really slipped. Sorry I owe you an > apology for this > > I am still not sure of this patch yet, lets get it right and merged > quickly. I will send my review later today I just realized that unlike what I said v3 of this patch is still wrong as it leaves the __init annotation on mxs_dma_init() which is called from (non __init) mxs_dma_probe(). v3 probably doesn't give a section mismatch warning because mxs_dma_init() is inlined. Really v2 is the one we should take which is at: https://lore.kernel.org/linux-arm-kernel/20220523132247.1429321-1-dario.binacchi@amarulasolutions.com/T/ Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel