From: Eliav Farber <farbere@amazon.com>
To: <jdelvare@suse.com>, <linux@roeck-us.net>,
<linux-hwmon@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<andriy.shevchenko@intel.com>, <sudipm.mukherjee@gmail.com>
Cc: <farbere@amazon.com>, <hhhawa@amazon.com>, <jonnyc@amazon.com>
Subject: [PATCH v6 0/2] Variety of fixes and new features for mr75203 driver
Date: Wed, 21 Sep 2022 12:18:42 +0000 [thread overview]
Message-ID: <20220921121844.8059-1-farbere@amazon.com> (raw)
List of fixes:
- Fix "intel,vm-map" property to be optional.
- Fix VM sensor allocation when "intel,vm-map" not defined.
- Fix multi-channel voltage reading.
- Fix voltage equation for negative source input.
- Modify the temperature equation according to series 5 datasheet.
- Fix coding style issue.
List of new features:
- Modify "reset" property to be optional.
- Add optional "moortec,vm-active-channels" property to define the number
of active channels per VM.
- Add support for mr76006 pre-scaler to multiply the voltage result by 2.
- Add support for series 6 temperature equation.
- Add coefficient properties to fine tune the temperature equation.
- Add debugfs to read and write temperature coefficients
---------
Changes between v5 and v6:
- fix undefined reference to `__divdi3' for 32-bit machines.
!!! Note: The patches of this series were pushed to hwmon-next and then
I got an automatic reply saying that these patches failed on some builds.
I sent separately an incremental patch which fixes the problem, and in
addition these two "replacement" patches for you do choose the option
you prefer. !!!
Changes between v4 and v5:
- 0004: Add detailed comment in code explaining the cast and the div instead of
right shift or use of BIT().
- 0011: Fix typo in description (nou --> not).
- 0020: Return j coefficient to use debugfs_create_file() instead of
debugfs_create_u32() because j is signed.
- 0021: Move the coding style patch to be last in the series (it does not fix
the code), and remove the "Fixes:" tag.
Changes between v3 and v4:
*) Provide a Fixes tag for all fixes in the series.
*) Start series with fixes.
*) New patch to add description in moortec,mr75203.yaml.
*) New patch to add moortec to vendor-prefixes.
*) Fix moortec,mr75203.yaml checker errors.
*) Remove validation of device-tree parameters.
*) Fix per patch specific comments (detailed in each patch).
Changes between v2 and v3:
*) Add "moortec" prefix to all new device-tree properties.
*) Change order of patches.
*) Add explanations to better understand the changes.
*) Change "reset" property to be optional and remove the
"reset-control-skip" property.
*) Split the patch for "fix multi-channel voltage reading" to two
patches.
*) Change pre-scaler property format and fix typo (scalar --> scaler).
*) Fix voltage equation to support negative values instead of limiting
value to zero.
*) Temperature equation - protect from overflow and add clamping.
*) Add new "moortec,ts-series" property to select between temperature
equation of series 5 or series 6.
Changes between v1 and v2:
*) Fix compilation error for patch 08/16:
"warning: ISO C90 forbids variable length array"
---------
Eliav Farber (2):
hwmon: (mr75203) modify the temperature equation according to series 5
datasheet
hwmon: (mr75203) add support for series 6 temperature equation
drivers/hwmon/mr75203.c | 91 +++++++++++++++++++++++++++++++++++++----
1 file changed, 83 insertions(+), 8 deletions(-)
--
2.37.1
next reply other threads:[~2022-09-21 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 12:18 Eliav Farber [this message]
2022-09-21 12:18 ` [PATCH v6 1/2] hwmon: (mr75203) modify the temperature equation according to series 5 datasheet Eliav Farber
2022-09-21 13:02 ` Sudip Mukherjee
2022-09-21 12:18 ` [PATCH v6 2/2] hwmon: (mr75203) add support for series 6 temperature equation Eliav Farber
2022-09-21 13:03 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220921121844.8059-1-farbere@amazon.com \
--to=farbere@amazon.com \
--cc=andriy.shevchenko@intel.com \
--cc=hhhawa@amazon.com \
--cc=jdelvare@suse.com \
--cc=jonnyc@amazon.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.