From: Christian Brauner <brauner@kernel.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Miklos Szeredi <mszeredi@redhat.com>,
linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Amir Goldstein <amir73il@gmail.com>,
David Howells <dhowells@redhat.com>,
Yu-li Lin <yulilin@google.com>,
Chirantan Ekbote <chirantan@chromium.org>
Subject: Re: [PATCH v3 8/9] vfs: open inside ->tmpfile()
Date: Wed, 21 Sep 2022 17:07:50 +0200 [thread overview]
Message-ID: <20220921150750.grruzm3copwproyu@wittgenstein> (raw)
In-Reply-To: <CAJfpegt8ZX88EbDqPci5ZOBDkrT-bZt=T+XWarw0=zpCAxkLwQ@mail.gmail.com>
On Wed, Sep 21, 2022 at 04:58:38PM +0200, Miklos Szeredi wrote:
> On Wed, 21 Sept 2022 at 11:08, Christian Brauner <brauner@kernel.org> wrote:
> >
> > On Tue, Sep 20, 2022 at 09:36:31PM +0200, Miklos Szeredi wrote:
> > > This is in preparation for adding tmpfile support to fuse, which requires
> > > that the tmpfile creation and opening are done as a single operation.
> > >
> > > Replace the 'struct dentry *' argument of i_op->tmpfile with
> > > 'struct file *'.
> > >
> > > Call finish_open_simple() as the last thing in ->tmpfile() instances (may
> > > be omitted in the error case).
> > >
> > > Change d_tmpfile() argument to 'struct file *' as well to make callers more
> > > readable.
> > >
> > > Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
> > > ---
> >
> > Seems fine to me. Fwiw, it feels like all the file->f_path.dentry derefs
> > could be wrapped in a helper similar to file_inode(). I know we have
> > file_dentry() but that calls d_real() so not sure if that'll be correct
> > for all updated callers,
>
> I don't think file_dentry() should be used for this.
>
> file_dentry() is basically a hack for overlayfs's "fake path" thing.
> It should only be used where strictly necessary. At one point it
> would be good to look again at cleaning this mess up.
Yeah, that's what I was getting at. The file_dentry() helper would
ideally just be as simple as file_inode() and then we'd have
file_dentry_real() for the stacking filesystem scenarios.
next prev parent reply other threads:[~2022-09-21 15:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 19:36 [PATCH v3 0/9] fuse tmpfile Miklos Szeredi
2022-09-20 19:36 ` [PATCH v3 1/9] cachefiles: tmpfile error handling cleanup Miklos Szeredi
2022-09-20 19:36 ` [PATCH v3 2/9] hugetlbfs: cleanup mknod and tmpfile Miklos Szeredi
2022-09-21 7:59 ` Christian Brauner
2022-09-20 19:36 ` [PATCH v3 3/9] vfs: add tmpfile_open() helper Miklos Szeredi
2022-09-21 8:09 ` Christian Brauner
2022-09-21 14:33 ` Miklos Szeredi
2022-09-20 19:36 ` [PATCH v3 4/9] cachefiles: use " Miklos Szeredi
2022-09-21 8:26 ` Christian Brauner
2022-09-21 14:44 ` Miklos Szeredi
2022-09-21 19:46 ` Al Viro
2022-09-22 8:04 ` Christian Brauner
2022-09-20 19:36 ` [PATCH v3 5/9] ovl: " Miklos Szeredi
2022-09-21 8:35 ` Christian Brauner
2022-09-20 19:36 ` [PATCH v3 6/9] vfs: make vfs_tmpfile() static Miklos Szeredi
2022-09-21 8:36 ` Christian Brauner
2022-09-20 19:36 ` [PATCH v3 7/9] vfs: move open right after ->tmpfile() Miklos Szeredi
2022-09-20 20:57 ` Al Viro
2022-09-21 3:06 ` Miklos Szeredi
2022-09-21 8:54 ` Christian Brauner
2022-09-21 14:53 ` Miklos Szeredi
2022-09-21 19:55 ` Al Viro
2022-09-21 9:03 ` Christian Brauner
2022-09-21 14:56 ` Miklos Szeredi
2022-09-21 15:09 ` Christian Brauner
2022-09-21 15:24 ` Miklos Szeredi
2022-09-20 19:36 ` [PATCH v3 8/9] vfs: open inside ->tmpfile() Miklos Szeredi
2022-09-21 9:08 ` Christian Brauner
2022-09-21 14:58 ` Miklos Szeredi
2022-09-21 15:07 ` Christian Brauner [this message]
2022-09-21 15:27 ` Miklos Szeredi
2022-09-21 15:36 ` Christian Brauner
2022-09-21 19:52 ` Al Viro
2022-09-20 19:36 ` [PATCH v3 9/9] fuse: implement ->tmpfile() Miklos Szeredi
2022-09-21 9:15 ` Christian Brauner
2022-09-21 15:00 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220921150750.grruzm3copwproyu@wittgenstein \
--to=brauner@kernel.org \
--cc=amir73il@gmail.com \
--cc=chirantan@chromium.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mszeredi@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yulilin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.