From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Rishabh Bhatnagar <risbhat@amazon.com>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
hch@lst.de, axboe@fb.com, kbusch@kernel.org, mbacco@amazon.com
Subject: Re: [PATCH] nvme-pci: Set min align mask before calculating max_hw_sectors
Date: Thu, 22 Sep 2022 07:58:15 +0200 [thread overview]
Message-ID: <20220922055815.GA27619@lst.de> (raw)
In-Reply-To: <871c0e19-9272-e92b-28dc-a50ae705bba8@grimberg.me>
On Wed, Sep 21, 2022 at 11:10:58AM +0300, Sagi Grimberg wrote:
>
>> If swiotlb is force enabled dma_max_mapping_size ends up calling
>> swiotlb_max_mapping_size which takes into account the min align
>> mask for the device.
>> Set the min align mask for nvme driver before calling
>> dma_max_mapping_size while calculating max hw sectors.
>
> Does this fix a specific bug? if so it needs a fixes tag so it can
> go to stable backports as well.
Hmm. Basically this is another fixlet for nvme on swiotlb, which
already drove adding the max_mapping size and the align_mask, and
it seems we still hadn't covered all corner cases properly. So
I think it basically has been broken since day 1, but nvme on
swiotlb only started becoming "interesting" with the trusted
hypervisor schemes.
next prev parent reply other threads:[~2022-09-22 5:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 19:19 [PATCH] nvme-pci: Set min align mask before calculating max_hw_sectors Rishabh Bhatnagar
2022-09-21 8:10 ` Sagi Grimberg
2022-09-22 5:58 ` Christoph Hellwig [this message]
2022-09-22 18:06 ` Bhatnagar, Rishabh
-- strict thread matches above, loose matches on Subject: below --
2022-09-27 17:23 Rishabh Bhatnagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922055815.GA27619@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mbacco@amazon.com \
--cc=risbhat@amazon.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.