From: Christoph Hellwig <hch@lst.de>
To: Liu Song <liusong@linux.alibaba.com>
Cc: axboe@kernel.dk, hch@lst.de, kbusch@kernel.org,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
sagi@grimberg.me
Subject: Re: [RFC PATCH] blk-mq: hctx has only one ctx mapping is no need to redirect the completion
Date: Thu, 22 Sep 2022 08:20:10 +0200 [thread overview]
Message-ID: <20220922062010.GA27946@lst.de> (raw)
In-Reply-To: <1663731123-81536-1-git-send-email-liusong@linux.alibaba.com>
On Wed, Sep 21, 2022 at 11:32:03AM +0800, Liu Song wrote:
> From: Liu Song <liusong@linux.alibaba.com>
>
> High-performance NVMe devices usually support a large hw queue, which
a larger number of?
> /*
> - * For a polled request, always complete locally, it's pointless
> - * to redirect the completion.
> + * For request which hctx has only one ctx mapping,
> + * or a polled request, always complete locally,
> + * it's pointless to redirect the completion.
> */
> - if (rq->cmd_flags & REQ_POLLED)
> + if (rq->mq_hctx->nr_ctx == 1 ||
> + rq->cmd_flags & REQ_POLLED)
Some very odd comment formatting and and indentation here.
next prev parent reply other threads:[~2022-09-22 6:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 16:40 [RFC PATCH] nvme: request remote is usually not involved for nvme devices Liu Song
2022-09-17 16:50 ` Jens Axboe
2022-09-18 16:10 ` Liu Song
2022-09-19 14:10 ` Jens Axboe
2022-09-19 14:35 ` Christoph Hellwig
2022-09-21 3:40 ` Liu Song
2022-09-21 3:32 ` [RFC PATCH] blk-mq: hctx has only one ctx mapping is no need to redirect the completion Liu Song
2022-09-22 6:20 ` Christoph Hellwig [this message]
2022-09-22 7:17 ` Liu Song
2022-09-22 8:27 ` [RFC PATCH v2] " Liu Song
2022-09-24 15:03 ` [RFC PATCH] " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922062010.GA27946@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=liusong@linux.alibaba.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.