From: Sascha Hauer <sha@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] ddr: imx8m: write fsp_table entry automatically
Date: Thu, 22 Sep 2022 11:51:56 +0200 [thread overview]
Message-ID: <20220922095156.GL986@pengutronix.de> (raw)
In-Reply-To: <20220921172052.2989506-1-m.felsch@pengutronix.de>
On Wed, Sep 21, 2022 at 07:20:51PM +0200, Marco Felsch wrote:
> Currently the fsp_table must be set manually within the 'struct
> dram_timing_info'. Since the 'struct fsp_msg' already has all
> information needed for the fsp_table we can use it to set it
> automatically. This approach is less error-prone and avoids information
> duplication.
Is this really worth it? The whole dram timing code comes directly from
the NXP DRAM tools, so the fsp_table comes back with each new board or
with a DRAM timing update.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-09-22 10:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 17:20 [PATCH 1/2] ddr: imx8m: write fsp_table entry automatically Marco Felsch
2022-09-21 17:20 ` [PATCH 2/2] ARM: i.MX8M: remove fsp_table entry Marco Felsch
2022-09-22 9:51 ` Sascha Hauer [this message]
2022-09-22 9:54 ` [PATCH 1/2] ddr: imx8m: write fsp_table entry automatically Marco Felsch
2022-09-26 6:01 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922095156.GL986@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.