From: rwright@hpe.com
To: Vladimir Panteleev <git@vladimir.panteleev.md>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] watchdog: sp5100_tco: Add "action" module parameter
Date: Thu, 22 Sep 2022 11:36:35 -0600 [thread overview]
Message-ID: <20220922173635.GJ18783@rfwz62> (raw)
In-Reply-To: <20220920092721.7686-1-git@vladimir.panteleev.md>
On Tue, Sep 20, 2022 at 09:27:21AM +0000, Vladimir Panteleev wrote:
> Allow configuring the "action" bit, as documented in [1].
>
> Previously, the only action supported by this module was to reset the
> system (0). It can now be configured to power off (1) instead.
>
> [1]: https://www.amd.com/system/files/TechDocs/44413.pdf
The referenced AMD document 44413 is over 10 years old, and I'm
concerned when I try to line that document up against the newer versions
that are implemented in AMD's EPYC processors, that the bit being
manipulated as SP5100_WDT_ACTION_RESET is effectively reserved in the
newer references, for example:
https://www.amd.com/system/files/TechDocs/55772-A1-PUB.zip
Is Core::X86::Msr::CpuWdtCfg in the newer document is the same as
WatchDogControl in the cited 44413.pdf? If so, then I would point out
that bit 2 is now included in what is called, CpuWdtTimeBase where
values 2-3H are reserved, meaning bit 2 effectively must be zero.
--
Randy Wright Hewlett Packard Enterprise
Phone: (970) 898-0998 Mail: rwright@hpe.com
next prev parent reply other threads:[~2022-09-22 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 9:27 [PATCH v2] watchdog: sp5100_tco: Add "action" module parameter Vladimir Panteleev
2022-09-22 17:36 ` rwright [this message]
2022-09-22 17:43 ` Guenter Roeck
2022-09-22 17:51 ` Jerry Hoemann
2022-09-25 19:54 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922173635.GJ18783@rfwz62 \
--to=rwright@hpe.com \
--cc=git@vladimir.panteleev.md \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.