From: Jakub Kicinski <kuba@kernel.org>
To: Li Zhong <floridsleeves@gmail.com>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com,
davem@davemloft.net
Subject: Re: [PATCH net-next v3] ethtool: tunnels: check the return value of nla_nest_start()
Date: Thu, 22 Sep 2022 19:28:04 -0700 [thread overview]
Message-ID: <20220922192804.09efa56f@kernel.org> (raw)
In-Reply-To: <20220921181716.1629541-1-floridsleeves@gmail.com>
On Wed, 21 Sep 2022 11:17:16 -0700 Li Zhong wrote:
> It will cause null pointer dereference when entry is used
> in nla_nest_end().
No it will not, there is no way for the flow to get to nla_nest_end()
if the skb is full :/
I will fix the commit message myself and apply but I'd like you to not
send more "error checking" patches to networking unless you're sure
that there is indeed a bug.
next prev parent reply other threads:[~2022-09-23 2:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 18:17 [PATCH net-next v3] ethtool: tunnels: check the return value of nla_nest_start() Li Zhong
2022-09-23 2:28 ` Jakub Kicinski [this message]
2022-09-23 21:39 ` Li Zhong
2022-09-23 2:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922192804.09efa56f@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=floridsleeves@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.