From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F690ECAAD8 for ; Fri, 23 Sep 2022 05:00:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229657AbiIWFAv (ORCPT ); Fri, 23 Sep 2022 01:00:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229624AbiIWFAu (ORCPT ); Fri, 23 Sep 2022 01:00:50 -0400 X-Greylist: delayed 1066 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 22 Sep 2022 22:00:47 PDT Received: from bmailout3.hostsharing.net (bmailout3.hostsharing.net [176.9.242.62]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E15AB118DFE for ; Thu, 22 Sep 2022 22:00:46 -0700 (PDT) Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS DV RSA Mixed SHA256 2020 CA-1" (verified OK)) by bmailout3.hostsharing.net (Postfix) with ESMTPS id 87060100DCECA; Fri, 23 Sep 2022 07:00:45 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 537D44F397; Fri, 23 Sep 2022 07:00:45 +0200 (CEST) Date: Fri, 23 Sep 2022 07:00:45 +0200 From: Lukas Wunner To: Yang Yingliang Cc: linux-spi@vger.kernel.org, broonie@kernel.org Subject: Re: [PATCH -next 2/6] spi: ath79: Switch to use devm_spi_alloc_master() Message-ID: <20220923050045.GA10288@wunner.de> References: <20220920134819.2981033-1-yangyingliang@huawei.com> <20220920134819.2981033-3-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220920134819.2981033-3-yangyingliang@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Tue, Sep 20, 2022 at 09:48:15PM +0800, Yang Yingliang wrote: > Switch to use devm_spi_alloc_master() to simpify error path. Unfortunately you're not removing the spi_master_put() from ath79_spi_remove() here either. So another use-after-free. :( Thanks, Lukas