From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12FC3ECAAD8 for ; Fri, 23 Sep 2022 06:46:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230242AbiIWGqG (ORCPT ); Fri, 23 Sep 2022 02:46:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230183AbiIWGqF (ORCPT ); Fri, 23 Sep 2022 02:46:05 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40C0112755F for ; Thu, 22 Sep 2022 23:46:05 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id A67DB68AFE; Fri, 23 Sep 2022 08:46:02 +0200 (CEST) Date: Fri, 23 Sep 2022 08:46:02 +0200 From: Christoph Hellwig To: Christian Brauner Cc: linux-fsdevel@vger.kernel.org, Seth Forshee , Christoph Hellwig , Al Viro Subject: Re: [PATCH 03/29] fs: add new get acl method Message-ID: <20220923064602.GC16489@lst.de> References: <20220922151728.1557914-1-brauner@kernel.org> <20220922151728.1557914-4-brauner@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220922151728.1557914-4-brauner@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org The new method looks good to me, but the patch structuring here where we add just the method without caller, than a bunch of instances and only then use them seems odd to me. Isn't there some better way to make sure that the newly wire up instances actually get used from the start?