From: Christoph Hellwig <hch@lst.de>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: axboe@kernel.dk, hch@lst.de, kbusch@kernel.org,
io-uring@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, gost.dev@samsung.com
Subject: Re: [PATCH for-next v8 5/5] nvme: wire up fixed buffer support for nvme passthrough
Date: Fri, 23 Sep 2022 17:40:41 +0200 [thread overview]
Message-ID: <20220923154041.GD21275@lst.de> (raw)
In-Reply-To: <20220923092854.5116-6-joshi.k@samsung.com>
On Fri, Sep 23, 2022 at 02:58:54PM +0530, Kanchan Joshi wrote:
> if (!vec)
> + if (!fixedbufs)
> + ret = blk_rq_map_user(q, req, NULL,
> + nvme_to_user_ptr(ubuffer), bufflen,
> + GFP_KERNEL);
> + else {
> + struct iov_iter iter;
> +
> + ret = io_uring_cmd_import_fixed(ubuffer, bufflen,
> + rq_data_dir(req), &iter, ioucmd);
> + if (ret < 0)
> + goto out;
> + ret = blk_rq_map_user_bvec(req, &iter);
> + }
Given that the fixedufs case doesn't handle the vec case we can
do with some untangling and a single level of indentation here.
Even with that a WARN_ON_ONCE() for that impossible case would be good
to have, though.
next prev parent reply other threads:[~2022-09-23 15:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220923093906epcas5p1308a262f3de722a923339c2e804fc5ee@epcas5p1.samsung.com>
2022-09-23 9:28 ` [PATCH for-next v8 0/5] fixed-buffer for uring-cmd/passthru Kanchan Joshi
2022-09-23 9:28 ` [PATCH for-next v8 1/5] io_uring: add io_uring_cmd_import_fixed Kanchan Joshi
2022-09-23 9:28 ` [PATCH for-next v8 2/5] io_uring: introduce fixed buffer support for io_uring_cmd Kanchan Joshi
2022-09-23 9:28 ` [PATCH for-next v8 3/5] nvme: refactor nvme_alloc_user_request Kanchan Joshi
2022-09-23 15:38 ` Christoph Hellwig
2022-09-25 17:39 ` Kanchan Joshi
2022-09-25 19:43 ` Kanchan Joshi
2022-09-26 14:51 ` Christoph Hellwig
2022-09-27 16:57 ` Kanchan Joshi
2022-09-23 9:28 ` [PATCH for-next v8 4/5] block: add helper to map bvec iterator for passthrough Kanchan Joshi
2022-09-23 15:30 ` Christoph Hellwig
2022-09-23 9:28 ` [PATCH for-next v8 5/5] nvme: wire up fixed buffer support for nvme passthrough Kanchan Joshi
2022-09-23 15:40 ` Christoph Hellwig [this message]
2022-09-23 14:15 ` [PATCH for-next v8 0/5] fixed-buffer for uring-cmd/passthru Jens Axboe
2022-09-25 17:56 ` Kanchan Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220923154041.GD21275@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=gost.dev@samsung.com \
--cc=io-uring@vger.kernel.org \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.