From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/ncurses: drop our custom host build commands
Date: Fri, 23 Sep 2022 23:55:47 +0200 [thread overview]
Message-ID: <20220923235547.65ee6181@windsurf> (raw)
In-Reply-To: <20220830124423.164957-1-yann.morin.1998@free.fr>
On Tue, 30 Aug 2022 14:44:23 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> Commit bf446513e7e7 (ncurses: fix hanging installation due to old
> version of tic) introduced the build of the host tic, to be used by the
> target ncurses. That commit purportedly built a static tic, but that is
> (at least now) wrong: there is nothing that makes the build of tic
> static.
>
> Initially, host-ncurses was configured with --without-shared, but that
> only drives whether to generate shared libs or not, it does not drive
> whether to do a shared or static link of executables.
>
> And in any case, in af23d762e51b (ncurses: enable shared library build
> on the host) we explicitly stopped requesting the build of a static
> library, to instead require the build of a shared library.
>
> So, we never had a statically linked tic ever.
>
> Furthermore, we override the _BUKLLD_CMDS, but we do not provide any
> _INSTALL_CMDS. As a consequence, the full ncurses is installed, not just
> tic. And since we override the _BUILD_CMDS, the libraries are not built,
> so they get built during the install step.
>
> And we do indeed need the libraries (host-gettext needs them), and not
> just tic.
>
> So, just drop our custom _BUILD_CMDS and just build the whole package
> with the default settings. We keep the explicit use of --with-shared,
> as this is not the standard flag (--enable-shared) and it is not obvious
> what the default is.
>
> The set of files installed before and after this change is exactly the
> same, and tic still is an "ELF 64-bit LSB shared object" with a RUNPATH
> that still correctly points to $(HOST_DIR)/lib
>
> To be noted: there is no regressin in build time either, since we were
> already building everything anyway.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> ---
> package/ncurses/ncurses.mk | 10 ----------
> 1 file changed, 10 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-09-23 21:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 12:44 [Buildroot] [PATCH] package/ncurses: drop our custom host build commands Yann E. MORIN
2022-09-23 21:55 ` Thomas Petazzoni [this message]
2022-09-30 15:01 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220923235547.65ee6181@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.