Re: [Buildroot] [PATCH] Revert "configs/qemu_ppc64*: downgrade binutils to 2.36.1"

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Cédric, All,

On 2022-09-25 15:20 +0200, Cédric Le Goater spake thusly:
> On 9/25/22 14:40, Yann E. MORIN wrote:
> >On 2022-09-24 23:41 +0200, Cédric Le Goater spake thusly:
> >>This reverts commit 1e2fe860f3a261fc877591c056808d6fb30e25d4.
> >This is not really a revert,
> This is the result of the command :
>   git revert -s 1e2fe860f3a2
> So it is "really" a revert :)

Yes, it is a git-revert, i.e. ity is a tchnical revert.

However, a git-revert really means "that commit was wrong back at the
time, undo it". But in this case, the commit was correct, so we do not
want to git-revert it; at least, we do not want to inscribe in our git
log that this is a revert.

Instead, the conditions around have changed, which allows using the old
"code" (defconfig values in this case) again.

> >so I did some changes:
> >   - explictily force binutils 2.38
> I guess this is to make sure that 2.37 is not selected but when
> the current 2.38 is deprecated, all defconfigs will require an
> update. Since the default works fine, I don't think it is worth
> adding an extra dependency (until next breakage) or we could use
> a !2.37 dependency instead. I am not sure if this is possible
> though.

When we drop 2.38, having it referenced in the defconfig will help us
notice that something must be taken care of, and looking at the git log
will help us take a decision (keep the version around, bump the
defconfig, etc..)

In the defconfigs, we do not want to use the defaults; we want to use
explicit versions.

Granted, this is not always enforced, and the defconfigs we have are of
variable level of using explicit versions even if the default; this is
mostly the case for the kernel headers, though.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot