From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Jacob Kroon <jacob.kroon@gmail.com>
Cc: Oliver Hartkopp <socketcan@hartkopp.net>,
linux-can@vger.kernel.org, Dario Binacchi <dariobin@libero.it>,
Wolfgang Grandegger <wg@grandegger.com>
Subject: Re: [RFC can-next] can: remove obsolete PCH CAN driver
Date: Mon, 26 Sep 2022 10:25:26 +0200 [thread overview]
Message-ID: <20220926082526.ofoderi7wrpyolff@pengutronix.de> (raw)
In-Reply-To: <f9b37775-edd5-2a5b-18bc-b34bb69b8324@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1630 bytes --]
On 24.09.2022 22:24:07, Jacob Kroon wrote:
> On 9/24/22 19:44, Oliver Hartkopp wrote:
> > The PCH CAN driver is a driver for a Bosch C_CAN controller IP core which
> > is attached to the system via PCI. This code has been introduced in 2011
> > by Oki Semiconductors developers to support the Intel Atom E6xx series
> > I/O Hub (aka EG20T IOH PCH CAN). Since 2012 the driver only has been
> > maintained by the kernel community.
> >
> > As there is a well maintained and continously tested C_CAN/D_CAN driver
> > which also supports the PCI configuration from the PCH CAN EG20T setup
> > this driver became obsolete.
> >
> > Cc: Jacob Kroon <jacob.kroon@gmail.com>
> > Cc: Marc Kleine-Budde <mkl@pengutronix.de>
> > Cc: Dario Binacchi <dariobin@libero.it>
> > Cc: Wolfgang Grandegger <wg@grandegger.com>
> > Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
> > ---
> > drivers/net/can/Kconfig | 8 -
> > drivers/net/can/Makefile | 1 -
> > drivers/net/can/c_can/Kconfig | 3 +-
> > drivers/net/can/pch_can.c | 1249 ---------------------------------
> > 4 files changed, 2 insertions(+), 1259 deletions(-)
> > delete mode 100644 drivers/net/can/pch_can.c
> >
>
> Given that the current PCH driver will lockup on my system I'm all for
> removing it.
Should I add your Acked-by?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-09-26 8:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-24 17:44 [RFC can-next] can: remove obsolete PCH CAN driver Oliver Hartkopp
2022-09-24 20:24 ` Jacob Kroon
2022-09-25 11:45 ` Oliver Hartkopp
2022-09-26 8:25 ` Marc Kleine-Budde [this message]
2022-09-26 8:55 ` Jacob Kroon
2022-10-04 18:44 ` Oliver Hartkopp
2022-10-05 7:06 ` Marc Kleine-Budde
2022-10-05 9:09 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220926082526.ofoderi7wrpyolff@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=dariobin@libero.it \
--cc=jacob.kroon@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.