From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Alexandru Ardelean <ardeleanalex@gmail.com>
Cc: Daniel Price <daniel.price@gmail.com>,
Martin Bark <martin@barkynet.com>,
"Yann E. MORIN" <yann.morin.1998@free.fr>,
Buildroot List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH RFC 2/4] package/nodejs-bin: new package
Date: Mon, 26 Sep 2022 10:05:52 +0200 [thread overview]
Message-ID: <20220926100552.212e0d83@windsurf> (raw)
In-Reply-To: <CA+U=DsrR9+WK3gWR=N3FRiOokuLzLWt=mYeWMbRU-Pme=wJN_Q@mail.gmail.com>
On Mon, 26 Sep 2022 10:56:10 +0300
Alexandru Ardelean <ardeleanalex@gmail.com> wrote:
> Silly question(s) from me.
> This may go against some BR guidelines.
>
> But, what if you were to add a 'package/nodejs/version' file and
> include it here like `include ../package/nodejs/version` ?
We've not been doing this like this for now.
> Another idea would be to maybe add a new folder sub-level like
> 'package/nodejs/nodejs/<the current one>' &
> 'package/nodejs/nodejs-bin/<this new one>' and have a
> 'package/nodejs/nodejs.mk' which includes the mk files from the
> sub-dirs.
See the commit log for PATCH 3/4, which says:
"""
One possible alternate organization is to have package/nodejs/ contain
all three packages: package/nodejs/nodejs/, package/nodejs/nodejs-src,
package/nodejs/nodejs-bin, which would allow to more easily share a
few common variables (version, license, license files, CPE ID, etc.).
"""
:-)
BTW, did you confirm that with the latest master you can now build
NodeJS correctly for your scenario?
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-09-26 8:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 20:40 [Buildroot] [PATCH RFC 1/4] DEVELOPERS: add Thomas Petazzoni for nodejs Thomas Petazzoni via buildroot
2022-09-25 20:40 ` [Buildroot] [PATCH RFC 2/4] package/nodejs-bin: new package Thomas Petazzoni
2022-09-26 7:56 ` Alexandru Ardelean
2022-09-26 8:05 ` Thomas Petazzoni via buildroot [this message]
2022-09-26 8:08 ` Alexandru Ardelean
2022-09-25 20:40 ` [Buildroot] [PATCH RFC 3/4] package/nodejs: make host package a virtual package Thomas Petazzoni
2022-09-25 20:43 ` Thomas Petazzoni
2022-09-25 20:40 ` [Buildroot] [PATCH RFC 4/4] support/testing/tests/package/test_nodejs: test both host-nodejs-bin and host-nodejs-src Thomas Petazzoni
2022-09-26 8:00 ` [Buildroot] [PATCH RFC 1/4] DEVELOPERS: add Thomas Petazzoni for nodejs Alexandru Ardelean
2023-10-02 15:42 ` Arnout Vandecappelle via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220926100552.212e0d83@windsurf \
--to=buildroot@buildroot.org \
--cc=ardeleanalex@gmail.com \
--cc=daniel.price@gmail.com \
--cc=martin@barkynet.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.