From: Florian Westphal <fw@strlen.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Florian Westphal <fw@strlen.de>,
netdev@vger.kernel.org, tgraf@suug.ch, urezki@gmail.com,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Martin Zaharinov <micron10@gmail.com>,
Michal Hocko <mhocko@suse.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH net] rhashtable: fix crash due to mm api change
Date: Mon, 26 Sep 2022 12:24:56 +0200 [thread overview]
Message-ID: <20220926102456.GC12777@breakpoint.cc> (raw)
In-Reply-To: <YzF8Ju+jXe09f0kj@gondor.apana.org.au>
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Only in the case of kvzalloc. We expect kzalloc to fail, that's
> why it gets NOWARN. There is no sane reason for kvzalloc to fail
> so it should warn.
To me a WARN() only has one purpose:
It will get reported to mailing list and a developer can use that
to develop a patch/fix.
In memory allocation failure, there is no bug, so nothing to fix,
so WARN is useless.
next prev parent reply other threads:[~2022-09-26 10:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 8:31 [PATCH net] rhashtable: fix crash due to mm api change Florian Westphal
2022-09-26 8:37 ` Herbert Xu
2022-09-26 8:50 ` Florian Westphal
2022-09-26 9:37 ` Herbert Xu
2022-09-26 10:05 ` Florian Westphal
2022-09-26 10:17 ` Herbert Xu
2022-09-26 10:24 ` Florian Westphal [this message]
2022-09-27 7:04 ` Herbert Xu
2022-09-26 8:59 ` Michal Hocko
2022-09-26 15:19 ` Florian Westphal
2022-09-27 4:24 ` Martin Zaharinov
2022-09-27 4:44 ` [Intel-wired-lan] " Martin Zaharinov
2022-09-27 4:44 ` Martin Zaharinov
2022-09-27 16:05 ` [Intel-wired-lan] " Martin Zaharinov
2022-09-27 16:05 ` Martin Zaharinov
2022-09-28 8:57 ` Florian Westphal
2022-09-29 20:57 ` Martin Zaharinov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220926102456.GC12777@breakpoint.cc \
--to=fw@strlen.de \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=micron10@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tgraf@suug.ch \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.