From: Kees Cook <keescook@chromium.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-toolchains@vger.kernel.org
Subject: Re: [PATCH v2] minmax: clamp more efficiently by avoiding extra comparison
Date: Mon, 26 Sep 2022 11:30:58 -0700 [thread overview]
Message-ID: <202209261130.2C96929E38@keescook> (raw)
In-Reply-To: <CAHmME9pRXpTc2g5R-xj7hTrG00iQ6WLSSRooag1NPzJnyV90Nw@mail.gmail.com>
On Mon, Sep 26, 2022 at 02:23:48PM +0200, Jason A. Donenfeld wrote:
> On Mon, Sep 26, 2022 at 12:00 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > On Sat, Sep 24, 2022 at 12:37:26PM +0200, Jason A. Donenfeld wrote:
> > > On Fri, Sep 23, 2022 at 03:54:12PM -0700, Andrew Morton wrote:
> > > > On Fri, 23 Sep 2022 17:40:01 +0200 "Jason A. Donenfeld" <Jason@zx2c4.com> wrote:
> >
> > ...
> >
> > > Worth noting, by the way, is that the input validation check already
> > > caught a bug when 0day test bot choked:
> > >
> > > https://lore.kernel.org/linux-hwmon/20220924101151.4168414-1-Jason@zx2c4.com/
> >
> > Hooray, it was a good idea! :-)
> >
> > > So, options:
> > > 1) Keep this patch as-is, because it is useful on modern compilers.
> > > 2) Add an ifdef on compiler version, so we generate the best code in
> > > each case.
> > > 3) Go back to testing twice, but keep the checker macro because it's
> > > apparently useful.
> > > 4) Do nothing and discard this series.
> > >
> > > Any of those are okay with me. Opinions?
> >
> > I tend to case 3) (I believe you typo'ed double 2) cases) and apply the rest
> > as a separate change with all downsides explained (kinda 1) approach).
>
> Alright, I'll do that. v3 on its way, then.
Cool. I've dropped v2 from my -next tree.
--
Kees Cook
next prev parent reply other threads:[~2022-09-26 18:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 10:06 [PATCH] minmax: clamp more efficiently by avoiding extra comparison Jason A. Donenfeld
2022-09-23 10:35 ` Andy Shevchenko
2022-09-23 10:40 ` Jason A. Donenfeld
2022-09-23 10:48 ` Jason A. Donenfeld
2022-09-23 15:12 ` Andy Shevchenko
2022-09-23 15:13 ` Jason A. Donenfeld
2022-09-23 15:40 ` [PATCH v2] " Jason A. Donenfeld
2022-09-23 16:41 ` Kees Cook
2022-09-23 16:42 ` Jason A. Donenfeld
2022-09-23 16:53 ` Andy Shevchenko
2022-09-23 16:54 ` Jason A. Donenfeld
2022-09-23 19:47 ` Kees Cook
2022-09-23 22:54 ` Andrew Morton
2022-09-24 0:02 ` Kees Cook
2022-09-24 10:37 ` Jason A. Donenfeld
2022-09-25 16:29 ` Andrew Morton
2022-09-26 10:00 ` Andy Shevchenko
2022-09-26 12:23 ` Jason A. Donenfeld
2022-09-26 13:34 ` [PATCH v3 1/2] minmax: sanity check constant bounds when clamping Jason A. Donenfeld
2022-09-26 13:34 ` [PATCH v3 2/2] minmax: clamp more efficiently by avoiding extra comparison Jason A. Donenfeld
2022-09-26 18:30 ` Kees Cook
2022-09-26 21:33 ` Jason A. Donenfeld
2022-09-26 13:46 ` [PATCH v3 1/2] minmax: sanity check constant bounds when clamping Andy Shevchenko
2022-09-26 18:26 ` Kees Cook
2022-10-04 13:41 ` Jason A. Donenfeld
2022-10-04 14:39 ` Kees Cook
2022-10-04 15:01 ` Jason A. Donenfeld
2022-09-26 18:30 ` Kees Cook [this message]
2022-09-23 15:10 ` [PATCH] minmax: clamp more efficiently by avoiding extra comparison Andy Shevchenko
2022-09-23 15:11 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209261130.2C96929E38@keescook \
--to=keescook@chromium.org \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.