From: Christoph Hellwig <hch@lst.de>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Jonathan Derrick <jonathan.derrick@intel.com>,
Revanth Rajashekar <revanth.rajashekar@intel.com>,
Jens Axboe <axboe@kernel.dk>, Keith Busch <kbusch@kernel.org>,
Jens Axboe <axboe@fb.com>, Sagi Grimberg <sagi@grimberg.me>,
Guenter Roeck <linux@roeck-us.net>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] nvme-hwmon: Cache-line-align the NVME SMART log-buffer
Date: Mon, 26 Sep 2022 16:39:59 +0200 [thread overview]
Message-ID: <20220926143959.GA19918@lst.de> (raw)
In-Reply-To: <20220925222325.irltbraf4e2j4vtq@mobilestation>
On Mon, Sep 26, 2022 at 01:23:25AM +0300, Serge Semin wrote:
> IMO both the approaches seem unclear if a reader doesn't know what
> they have been introduced for. Anyway do you insist on using the
> kmalloc-ed buffer here instead? If so I'll resubmit the series with
> this patch updated accordingly.
I don't like the __aligend version too much, but I can live with it if
you strongly prefer it.
next prev parent reply other threads:[~2022-09-26 15:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 19:19 [PATCH 0/2] block/nvme: Fix DMA-noncoherent platforms support Serge Semin
2022-09-09 19:19 ` [PATCH 1/2] nvme-hwmon: Cache-line-align the NVME SMART log-buffer Serge Semin
2022-09-09 19:42 ` Keith Busch
2022-09-09 20:53 ` Serge Semin
2022-09-09 20:36 ` Guenter Roeck
2022-09-10 5:30 ` Christoph Hellwig
2022-09-10 12:35 ` Serge Semin
2022-09-10 18:09 ` Serge Semin
2022-09-12 8:29 ` Christoph Hellwig
2022-09-25 22:23 ` Serge Semin
2022-09-26 14:39 ` Christoph Hellwig [this message]
2022-09-26 19:04 ` Serge Semin
2022-09-10 14:33 ` Guenter Roeck
2022-09-09 19:19 ` [PATCH 2/2] block: sed-opal: Cache-line-align the cmd/resp buffers Serge Semin
2022-09-10 5:32 ` Christoph Hellwig
2022-09-11 16:28 ` Serge Semin
2022-09-25 22:30 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220926143959.GA19918@lst.de \
--to=hch@lst.de \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=fancer.lancer@gmail.com \
--cc=jonathan.derrick@intel.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=revanth.rajashekar@intel.com \
--cc=sagi@grimberg.me \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.