From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2688DC32771 for ; Tue, 27 Sep 2022 02:31:51 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 54D4D822; Tue, 27 Sep 2022 04:30:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 54D4D822 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1664245909; bh=iE09VGekRQ8YujdOIAidDZPWqvogpi5SYGTWTGNiutI=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=fePHXBKlRTDUtTHlNext9t09yXsqEeT+SIXj40A6nX9QgyuynBhKaSAKS2hFNCZIa KJsu/wUeD/naISPs+II4H/I4w7zooNXzm5E7pfr+yL+74bG+APqYSqOn7QPZ2Jss1N KO7/1NdJG9qbLPSqn79gn9YFbcUl+yx1tfWqKef8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AEE1DF8024C; Tue, 27 Sep 2022 04:30:58 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id F1924F8025E; Tue, 27 Sep 2022 04:30:57 +0200 (CEST) Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 788B2F8011C for ; Tue, 27 Sep 2022 04:30:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 788B2F8011C Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="JLnoASLU" Received: by mail-pj1-x102b.google.com with SMTP id rt12so7983995pjb.1 for ; Mon, 26 Sep 2022 19:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=M6ZjbEpb/UdQZtA16p01zlM8hWd+9RIaPah6OiYEF9s=; b=JLnoASLUHeDPUf6dI39o1+5rs9AzhUtl9AApNwejURiKdFKySH7qwrWxoCD8281JdM s5VZBA3uCrzXB/vkhMOC5uX2WZ+020yhDkhV3nLWWe84wG1IrVbTXzd7loPubISbr7Lq REDFu0hTtFb8HmZWdQO+0sCSW2tjfT1AFwfcU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=M6ZjbEpb/UdQZtA16p01zlM8hWd+9RIaPah6OiYEF9s=; b=7WCxLxeAUpNQEW8ZmIqX04yADvNWJdxKptQxrbJecJXDl9UaReB4jlb2yr5v6liMDZ s7+i1JAC+ww0Fj66CgW07EOhleKyvPZeU0I14gP29AoWIT+LYZVTFwnCSKzzE9uOp73r LSn5097JgNa/lPSJSG2jm8G3dXLkM7MxvmhZ2K1KK0YgBNm6Wxv8m2j38PkvQfn8QjcN 1ljJmXt3iTcDI4v4QtZqWFBacOhXUdvpaa5AxFu2+Usa6Y0OIF82lYBmYqRquKTEEDpq ZYfI6ebFR4FMUd7MaKqxapIxbFdyEC6Vv0zf8AfIpkR+VnQ7jQkxF38xqw/UjphPU6E3 jT6Q== X-Gm-Message-State: ACrzQf2UCUzri7jRMvS3m42+KlEh3iRhEJXosgo2RNnjcKbMhzHuckly 1zAsgnH79oYQdZouhVHXMofYMN/9AKMjDQ== X-Google-Smtp-Source: AMsMyM4fVILya89l/buI/6YDmjZuGWn9S4tka+jx7icqv87/971kE+MPYocVhEp623vm5hAMuZB50Q== X-Received: by 2002:a17:90b:4c8b:b0:203:5db5:8b71 with SMTP id my11-20020a17090b4c8b00b002035db58b71mr1933594pjb.51.1664245847736; Mon, 26 Sep 2022 19:30:47 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t6-20020a1709027fc600b00176dc72ad88sm117601plb.287.2022.09.26.19.30.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 19:30:46 -0700 (PDT) Date: Mon, 26 Sep 2022 19:30:46 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Subject: Re: [PATCH][next] ASoC: Intel: Skylake: Replace zero-length arrays with DECLARE_FLEX_ARRAY() helper Message-ID: <202209261930.A40876B@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: alsa-devel@alsa-project.org, Cezary Rojewski , Kai Vehmanen , Peter Ujfalusi , Takashi Iwai , Pierre-Louis Bossart , Ranjani Sridharan , Liam Girdwood , Mark Brown , linux-hardening@vger.kernel.org, Bard Liao , linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Sep 26, 2022 at 05:58:17PM -0500, Gustavo A. R. Silva wrote: > Zero-length arrays are deprecated and we are moving towards adopting > C99 flexible-array members, instead. So, replace zero-length arrays > declarations in anonymous union with the new DECLARE_FLEX_ARRAY() > helper macro. > > This helper allows for flexible-array members in unions. > > Link: https://github.com/KSPP/linux/issues/193 > Link: https://github.com/KSPP/linux/issues/226 > Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80F3CC32771 for ; Tue, 27 Sep 2022 02:30:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230198AbiI0Cau (ORCPT ); Mon, 26 Sep 2022 22:30:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230175AbiI0Cat (ORCPT ); Mon, 26 Sep 2022 22:30:49 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E86CB2847 for ; Mon, 26 Sep 2022 19:30:48 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id iw17so7915192plb.0 for ; Mon, 26 Sep 2022 19:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=M6ZjbEpb/UdQZtA16p01zlM8hWd+9RIaPah6OiYEF9s=; b=JLnoASLUHeDPUf6dI39o1+5rs9AzhUtl9AApNwejURiKdFKySH7qwrWxoCD8281JdM s5VZBA3uCrzXB/vkhMOC5uX2WZ+020yhDkhV3nLWWe84wG1IrVbTXzd7loPubISbr7Lq REDFu0hTtFb8HmZWdQO+0sCSW2tjfT1AFwfcU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=M6ZjbEpb/UdQZtA16p01zlM8hWd+9RIaPah6OiYEF9s=; b=eX4GfeazU/94clePLqmd2HmX7K/pXLRobjkdZASmN2JtZZpSTBLG7Y5syQT7wfGn4t 47NLTEdD6BEkzab5vKyv8igqhVExu2+9liSE83n6AYKDsDK764ZiWioyMjQD3EDgZrTJ af7b9TVQrJmew8y6NiPRHQMb4k1OjJdkqPY/Fp1vjawbWag/5V/rzlZT8rmC0Zf/CPNj 00RG25gOBmyFJ2aq5OM0m8UEq9wjsBhRogxmqsjwQ7dYLuGvnM3oGs33OAbOqawZ1rpP 8PuXVJFoZQzQVRP9psyp15NlfGmU28kM2GH01NqU0TXAfwWPBtM7lPm4y72NKgzM/Ow7 +CmQ== X-Gm-Message-State: ACrzQf0heWbMuLxeky9rC1L8zNXy8Bq7O9qWsRe9l67ald/c7/A1oybA ej87OgDSt65MkHtKyeR/Q7z4JA== X-Google-Smtp-Source: AMsMyM4fVILya89l/buI/6YDmjZuGWn9S4tka+jx7icqv87/971kE+MPYocVhEp623vm5hAMuZB50Q== X-Received: by 2002:a17:90b:4c8b:b0:203:5db5:8b71 with SMTP id my11-20020a17090b4c8b00b002035db58b71mr1933594pjb.51.1664245847736; Mon, 26 Sep 2022 19:30:47 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t6-20020a1709027fc600b00176dc72ad88sm117601plb.287.2022.09.26.19.30.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 19:30:46 -0700 (PDT) Date: Mon, 26 Sep 2022 19:30:46 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] ASoC: Intel: Skylake: Replace zero-length arrays with DECLARE_FLEX_ARRAY() helper Message-ID: <202209261930.A40876B@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Mon, Sep 26, 2022 at 05:58:17PM -0500, Gustavo A. R. Silva wrote: > Zero-length arrays are deprecated and we are moving towards adopting > C99 flexible-array members, instead. So, replace zero-length arrays > declarations in anonymous union with the new DECLARE_FLEX_ARRAY() > helper macro. > > This helper allows for flexible-array members in unions. > > Link: https://github.com/KSPP/linux/issues/193 > Link: https://github.com/KSPP/linux/issues/226 > Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook