All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Guru Das Srinagesh <quic_gurus@quicinc.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	~postmarketos/upstreaming@lists.sr.ht,
	martin.botka@somainline.org,
	angelogioacchino.delregno@somainline.org,
	marijn.suijten@somainline.org, jamipkettunen@somainline.org,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Robert Marko <robimarko@gmail.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: firmware: document Qualcomm SM6375 SCM
Date: Mon, 26 Sep 2022 15:17:40 -0500	[thread overview]
Message-ID: <20220926201740.GA2726270-robh@kernel.org> (raw)
In-Reply-To: <20220926165904.GA17938@quicinc.com>

On Mon, Sep 26, 2022 at 09:59:04AM -0700, Guru Das Srinagesh wrote:
> On Sep 24 2022 10:17, Krzysztof Kozlowski wrote:
> > On 24/09/2022 02:09, Guru Das Srinagesh wrote:
> > > On Sep 21 2022 20:43, Konrad Dybcio wrote:
> > >> Does it? I did not define this compatible in the driver, so it does
> > >> not consume any clocks.
> > > 
> > > The bindings should describe only those compatibles that the driver supports -
> > > that is, both the driver and its bindings should be in sync.
> > 
> > That's not entirely true. Bindings describe the hardware in the most
> > complete way we can. Not the driver. Whether driver supports something
> > or not, is not relevant here, except that we don't want to document
> > non-existing things or stuff out of tree.
> 
> Is this only applicable to compatibles or device tree properties in general?
> 
> > > 
> > > Could you please update the driver with this compatible as well? Let's not
> > > merge this change without that first.
> > 
> > This could be even merged without change in the driver. However it's not
> > the case here as driver already supports it, so your request is fulfilled.
> 
> My concern is that if somebody specifies a compatible/device tree property that
> the driver doesn't support, their expectations from adding that change will not
> be met. In addition to having the bindings describe HW in full, I think the
> driver should also be in sync with it for this reason.

Which driver? From u-boot, *BSD, Linux, TF-A, ...?

Rob

  reply	other threads:[~2022-09-26 20:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-21  0:10 [PATCH] dt-bindings: firmware: document Qualcomm SM6375 SCM Konrad Dybcio
2022-09-21  7:07 ` Krzysztof Kozlowski
2022-09-21 18:43   ` Konrad Dybcio
2022-09-21 19:06     ` Krzysztof Kozlowski
2022-09-21 21:07       ` Konrad Dybcio
2022-09-22  6:36         ` Krzysztof Kozlowski
2022-09-24  0:09     ` Guru Das Srinagesh
2022-09-24  8:17       ` Krzysztof Kozlowski
2022-09-26 16:59         ` Guru Das Srinagesh
2022-09-26 20:17           ` Rob Herring [this message]
2022-09-27 11:42           ` Krzysztof Kozlowski
2022-09-28  6:26             ` Guru Das Srinagesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220926201740.GA2726270-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=angelogioacchino.delregno@somainline.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jamipkettunen@somainline.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=martin.botka@somainline.org \
    --cc=quic_gurus@quicinc.com \
    --cc=robimarko@gmail.com \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.